Closed Bug 1410490 Opened 3 years ago Closed 3 years ago

Port bug 1404451 to TB: Update color of glass borders around the UI

Categories

(Thunderbird :: Theme, enhancement)

All
Windows 7
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1404451 updated the color for the border around the content of Windows 7 Aero. We can update our color too and switch to variable.
Switching to variable, except for Lightning and the activity window because Lightning is also used in SM which doesn't have this variable and the activity window doesn't use messenger.css. It makes no sense to define this variables as there are too little references to the variable.

The color change of FX: https://hg.mozilla.org/mozilla-central/rev/e3018533b2fb

To test it, you need to switch to Aero. The grey of the border has very slightly changed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8920662 - Flags: review?(jorgk)
Comment on attachment 8920662 [details] [diff] [review]
glassShadowColor.patch

Very hard to see any difference here, particularly given that Glass has transparent borders and the colour depends on what's behind. I tried putting the window in front of a white background (Notepad window) and still couldn't see anything. I assume I was meant to look at the border of the main window amongst other things.

As an aside, I noticed that my custom CSS
#mail-toolbar-menubar2 { -moz-box-ordinal-group: 10 !important; }
#tabs-toolbar { -moz-box-ordinal-group: 20 !important; }
for placing the menu bar on top using Glass doesn't work correctly any more.

Should you land the patch, please change "around the UI" to "in the UI" (yes, I know, copied from the FF bug) in the commit message.
Attachment #8920662 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7bbf385fdbb0
Port bug 1404451 to TB: Update color of the outer glass borders. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.