Closed Bug 1410496 Opened 7 years ago Closed 7 years ago

Night mode CSS follow up: background-image gets inverted

Categories

(Firefox for iOS :: General, enhancement, P1)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fxios 10.0 ---
fxios-v10.0 --- verified
fxios-v11.0 --- verified

People

(Reporter: garvan, Assigned: justindarc)

References

Details

Attachments

(1 file)

GitHub Pull Request
55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
On nytimes, div with background-image gets inverted: See https://github.com/mozilla-mobile/firefox-ios/pull/3324#issuecomment-338258862
status-fxios-v10.0: --- → affected
tracking-fxios: ? → 10.0
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Priority: -- → P3
Bug 1411566 has identified some graphical issues with night mode. It is unclear if this is just a bug in WebKit with CSS filters on certain websites, but we should also re-invert brightness for any elements matching `[style*="background-image"]` before shipping this feature.
Priority: P3 → P2
See Also: → 1411566
Priority: P2 → P1
Attached file GitHub Pull Request —
Since you're familiar with MutationObserver, could you please review? :-)
Attachment #8922927 - Flags: review?(sarentz)
Comment on attachment 8922927 [details] [review] GitHub Pull Request Carrying over R+ from Slack.
Attachment #8922927 - Flags: review?(sarentz) → review+
Verifying as fix on master 73081c03882 and beta 10.0(7473). In Night mode, background images now get inverted.
Status: RESOLVED → VERIFIED
status-fxios-v10.0: affected → verified
status-fxios-v11.0: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: