1410504 - Sort out how or whether mParser should affect editing state on HTML documents

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P5)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1384606 comment 4.  nsHTMLDocument::DeferredContentEditableCountChange bails out if mParser is non-null, but nsHTMLDocument::EndUpdate calls MaybeEditingStateChanged() which does not consider mParser and just looks at mContentEditableCount.  So any codepath that calls DeferredContentEditableCountChange while not in an update will basically defer "until the next update", which is not a very useful thing to do.

Mats, do you know anything about this stuff?  Peter thought you might...

Comment 1

[Mats Palmgren (inactive)]

No, not really.  I've only touched this code tangentially in bug 842166.

Fwiw, I thought the mParser check was an optimization to delay the work
until EndLoad.
http://searchfox.org/mozilla-central/rev/1c4da216e00ac95b38a3f236e010b31cdfaae03b/dom/html/nsHTMLDocument.cpp#844-845

Comment 2

[Boris Zbarsky [:bzbarsky]]

OK, that matches Peter's recollection, but it's totally ineffective at that per comment 0...  Looks like that's been true ever since bug 395340.

Given that, I suspect we should just remove the mParser check....

Comment 3

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.