Closed Bug 1410518 Opened 3 years ago Closed 3 years ago

Change nsIRDFDataSource URI to ACString

Categories

(Core Graveyard :: RDF, defect)

defect
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I thought this would be useful for bug 1381725 to get rid of some of strdup calls. I am not super used to mozilla string classes, is using SetIsVoid(true) correct?
Attachment #8920690 - Flags: review?(nfroyd)
Assignee: nobody → evilpies
Comment on attachment 8920690 [details] [diff] [review]
Change nsIRDFDataSource URI to ACString

Review of attachment 8920690 [details] [diff] [review]:
-----------------------------------------------------------------

SetIsVoid() is the correct thing to do here.  Thank you for this, this looks great!
Attachment #8920690 - Flags: review?(nfroyd) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fecdd6a3f847
Change nsIRDFDataSource URI to ACString. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/fecdd6a3f847
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.