Closed Bug 1410568 Opened 7 years ago Closed 7 years ago

Update rustc tooltool package to 1.20

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file)

[tooltool] upgrade rustc packages
6.54 KB, patch
frg
: review+
Details | Diff | Splinter Review 
Busted due to old rustc compiler.
Summary: Update rustc tooltool to 1.20+ → Port relevant parts of |Bug 1391427 - Package upstream rust in taskcluster| to SeaMonkey
From what I can tell, they aren't using actual tooltool packages now. Instead,
they grab the source(?) from rust-lang.org, build + pack it up such that
it can be used by their taskcluster process.

So no more fiddling with rustc tooltool packages.
but apparently tooltool packages for rustc 1.20 do exist.  \o/
Summary: Port relevant parts of |Bug 1391427 - Package upstream rust in taskcluster| to SeaMonkey → Update rustc tooltool package to 1.20
Assignee: nobody → ewong
Status: NEW → ASSIGNED

        Attachment #8920751 -
        Flags: review?(frgrahl)

    
    

    
  
going to go for a post-land-review to clear the bustage

    
    

    
  
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/5e346bc9fee6
Update rustc to 1.20 r=bustagefix
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
    

    
  
That said.. I'm wondering if it makes sense to do the same thing, as in grab the latest and repack it?

    
  
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Comment on attachment 8920751 [details] [diff] [review]
[tooltool] upgrade rustc packages

Looks good. Sorry knew about it for a week but didn't find the time to file a bug.

        Attachment #8920751 -
        Flags: review?(frgrahl) → review+

    
    

    
  
Comment on attachment 8920751 [details] [diff] [review]
[tooltool] upgrade rustc packages

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined:  cannot build.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:none

        Attachment #8920751 -
        Flags: approval-comm-release?

    
    

    
  
Comment on attachment 8920751 [details] [diff] [review]
[tooltool] upgrade rustc packages

never mind..  merge issue.

        Attachment #8920751 -
        Flags: approval-comm-release?

    
  
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED

    
    

    
  
Last 56 / 2.53 changeset in m-r is d4134557db7c and tagged with FIREFOX_RELEASE_56_END

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: