1410569 - Saving an existing translation shows me as the translator

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Khaled Hosny]

Hitting Save for an existing translation without changing anything sets me as the translator. Oddly enough, it keeps the translation date unchanged.

I expect saving an unchanged translation to make no changes to the translation whatsoever.

Comment 1

[Matjaz Horvat [:mathjazz]]

Thanks for filing.

Note that only if the Translation author is not set, it gets set to the user that hits Save:
https://github.com/mozilla/pontoon/blob/master/pontoon/base/views.py#L708-L783

This is odd indeed and can easily give credit to Translator that is not the real author. Let's change that.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/841

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/9839dc542351429d2c26b7099bd9454400d23473
Fix bug 1410569: Do not update translation author if no changes made (#841)