1410591 - Address Bar retains focus after restoring the previous session

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Break browsing experiences after "Restore Previous Session"

Reproducible : always

Steps To Reproduce:
1. Open web page(e.g. https://developer.mozilla.org/en-US/Add-ons/WebExtensions ) in a 1st tab
2. Exit Firefox and restart Firefox
3. Alt > History > "Restore Previous Session"

Actual Results:
Address Bar steals focus.
Pressing arrow keys does not scroll the page.

Expected Results:
Content area should be focused.
Pressing arrow keys should scroll the page.

Comment 1

[Julien Cristau [:jcristau]]

Doesn't sound overly severe, not tracking.

Comment 2

[Gerry Chang [:gchang]]

Too late for 57, mark 57 won't fix.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a patch for 59 and likely for 60 but we can still take a patch for 61.

Comment 4

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b046cea86df063e60aaa291e1bf2bd300609450

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1410591 - Focus the content area when restoring the selected tab.

Review commit: https://reviewboard.mozilla.org/r/238714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238714/

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8969889 [details]
Bug 1410591 - Focus the content area when restoring the selected tab.

https://reviewboard.mozilla.org/r/238714/#review244554

Nice and thanks for the test!

::: browser/components/sessionstore/test/browser_focus_after_restore.js:1
(Diff revision 1)
> +/* This Source Code Form is subject to the terms of the Mozilla Public

Can you change this to a CC license, please?

::: browser/components/sessionstore/test/browser_focus_after_restore.js:11
(Diff revision 1)
> +  gURLBar.focus();
> +  is(document.activeElement, gURLBar.inputField, "urlbar is focused before restoring");
> +
> +  await promiseBrowserState({
> +    windows: [
> +      {

nit: I'd prefer this see this struct formatted as:
```js
await promiseBrowserState({
  windows: [{
    tabs: [{
      entries: [{
        url: "http://example.org/", triggeringPrincipal_base64
      }]
    }],
    selected: 1
  }]
});
```

... which looks more compact and legible.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8969889 [details]
Bug 1410591 - Focus the content area when restoring the selected tab.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238714/diff/1-2/

Comment 8

[Mozilla Autoland]

hg error in cmd: hg rebase -s e7ed16a8bc982da5b22986f09e9abd1a8226cb98 -d aac9f21986a7: abort: can't rebase public changeset e7ed16a8bc98
(see 'hg help phases' for details)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5dad10abab9
Focus the content area when restoring the selected tab. r=mikedeboer

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a5dad10abab9

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch for uplift

Approval Request Comment
[Feature/Bug causing the regression]: bug 1393802
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: manual verification might be a good idea despite the test. steps in comment 0.
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: very straightforward fix
[String changes made/needed]: /

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8970468 [details] [diff] [review]
patch for uplift

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb406489fc496eeb5e3aee59d97e30907b1dbba1

Comment 13

[Ciprian Georgiu, Desktop QA]

I have reproduced this bug on an affected Nightly build (2017-10-20) using STR from comment 0.

I cannot reproduce it anymore on latest Nightly 61.0a1 (2018-04-24) running Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.

Ni myself as a reminder to verify this on Beta too.

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8970468 [details] [diff] [review]
patch for uplift

At this stage in the cycle, I'd rather let this ride to 61 as it's not a new issue in 60.