Change CacheInfo interfaces to use ACString

RESOLVED FIXED in Firefox 58

Status

()

defect
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

This is useful for bug 1381725 to get rid of some of strdup calls.
Attachment #8920780 - Flags: review?(nfroyd)
Assignee: nobody → evilpies
Priority: -- → P5
Whiteboard: [necko-triaged]
Comment on attachment 8920780 [details] [diff] [review]
Change CacheInfo interfaces to use ACString

Review of attachment 8920780 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense to me; I'd like to double-check with a netwerk cache peer to make sure they don't see anything I missed.
Attachment #8920780 - Flags: review?(nfroyd)
Attachment #8920780 - Flags: review?(michal.novotny)
Attachment #8920780 - Flags: review+
Comment on attachment 8920780 [details] [diff] [review]
Change CacheInfo interfaces to use ACString

note that this is ONLY used for appcache (hence rarely), and that only some parts of the code you are changing here.  this is a non-maintained code!
Is Michal around to review this?
Attachment #8920780 - Flags: review?(michal.novotny) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f387c200939
Change CacheInfo interfaces in network to use ACString. r=michal,froydnj
https://hg.mozilla.org/mozilla-central/rev/3f387c200939
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.