1410620 - Change CacheInfo interfaces to use ACString

Status: RESOLVED FIXED

(Core :: Networking, defect, P5)

Description

[Tom S [:evilpie]]

Attachment: Change CacheInfo interfaces to use ACString

This is useful for bug 1381725 to get rid of some of strdup calls.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8920780 [details] [diff] [review]
Change CacheInfo interfaces to use ACString

Review of attachment 8920780 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense to me; I'd like to double-check with a netwerk cache peer to make sure they don't see anything I missed.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8920780 [details] [diff] [review]
Change CacheInfo interfaces to use ACString

note that this is ONLY used for appcache (hence rarely), and that only some parts of the code you are changing here.  this is a non-maintained code!

Comment 3

[Tom S [:evilpie]]

Is Michal around to review this?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f387c200939
Change CacheInfo interfaces in network to use ACString. r=michal,froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3f387c200939