Closed Bug 1410635 Opened 3 years ago Closed 3 years ago

No clear indication when attachment bucket in composer has focus

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

attachmentBucketFocus.patch
2.44 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
Bug1410635-Follow-up.patch
2.03 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
it's not easy to spot when the attachment bucket in composer has the focus. Only the the before focused attachment has a dotted focus ring and this isn't very clear the bucket has the focus.
This adds a focus ring inside the attachment bucket.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8920808 - Flags: review?(jorgk)
Comment on attachment 8920808 [details] [diff] [review]
attachmentBucketFocus.patch

Nice.
Attachment #8920808 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f01fe3bcd422
Give better feedback when the attachmentBucked is focused. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
Somehow the osx change lost the 'inset' attribute. Can I land it with DONTBUILD?
Attachment #8920870 - Flags: review?(jorgk)
Comment on attachment 8920870 [details] [diff] [review]
Bug1410635-Follow-up.patch

OK, I'll land this now but *without* the "Reorder Attachments Panel" stuff accidentally included here.
Attachment #8920870 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9760a85ceffe
Follow-up: add 'inset' attribute also to the osx rule. r=jorgk DONTBUILD
You need to log in before you can comment on or make changes to this bug.