1410654 - Extend WebRTC Scalar Telemetry probes

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nils Ohlmeier [:drno]]

As note in bug 1410560 all of our Scalar based WebRTC Telemetry probes expired in 57 already, because we did not noticed and there was no email notification.

I consider the values measured in these probes permanent monitoring data. Therefore we should extend their live time for now.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

Review commit: https://reviewboard.mozilla.org/r/191816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191816/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

Not sure if extending expire values needs approval or not...

Comment 3

[François Marier [:francois]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

https://reviewboard.mozilla.org/r/191816/#review197342

datareview+

::: toolkit/components/telemetry/Scalars.yaml:643
(Diff revision 1)
>        For more info on ICE, see https://tools.ietf.org/html/rfc5245
>        For more info on STUN, see https://tools.ietf.org/html/rfc5389
>        For more info on TURN, see https://tools.ietf.org/html/rfc5766
> -    expires: "57"
> +    expires: "62"
>      kind: uint
>      notification_emails:

Can you please add the email address of a person who is responsible for these probes?

Could be you, or a manager, but we are now asking for a person's email to be listed in all active probes.

Comment 4

[François Marier [:francois]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

(In reply to Nils Ohlmeier [:drno] from comment #2)
> Not sure if extending expire values needs approval or not...

Yes, these do need a quick review from data steward.

Comment 5

[Michael Froman [:mjf]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

https://reviewboard.mozilla.org/r/191816/#review197380

Looks good to me.

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191816/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6cbcef3f3e1
extend WebRTC Scalar Telemetry probes to 62. r=francois,mjf

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6cbcef3f3e1

Comment 9

[Sylvestre Ledru [:Sylvestre]]

is that something you are considering uplifting?

Comment 10

[Nils Ohlmeier [:drno]]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

Approval Request Comment
[Feature/Bug causing the regression]: Because of bug 1410560 we didn't get notified that these Telemetry probes expired in 57.
[User impact if declined]: Only indirectional by development not having visibility in 57 is WebRTC networking is doing worse then before.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Because it doesn't change code at all, but just increases version numbers for some Telemetry probes.
[String changes made/needed]: N/A

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8920824 [details]
Bug 1410654: extend WebRTC Scalar Telemetry probes to 62.

Very low risk, helps keep data monitoring flow uninterrupted, Beta57+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3abd8b94efc9