MacPorts in bootstrap.py is out of date, and fails on Sierra and High Sierra

RESOLVED FIXED in Firefox 58

Status

()

Core
Build Config
RESOLVED FIXED
28 days ago
27 days ago

People

(Reporter: Steve Armand, Assigned: Steve Armand)

Tracking

58 Branch
mozilla58
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

28 days ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171019100107

Steps to reproduce:

Run bootstrap.py on Mac OS X Sierra or High Sierra and select MacPorts.


Actual results:

MacPorts fails to install on High Sierra:

Please choose a package manager you'd like:
1. Homebrew
2. MacPorts (Does not yet support bootstrapping Firefox for Android.)
Your choice:
2
Traceback (most recent call last):
  File "bootstrap.py", line 170, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 161, in main
    dasboot.bootstrap()
  File "/var/folders/hc/8jjz1pjx2j7blyyyp9d1zdrh0000gn/T/tmpfZsXVt/mozboot/bootstrap.py", line 292, in bootstrap
    
  File "/var/folders/hc/8jjz1pjx2j7blyyyp9d1zdrh0000gn/T/tmpfZsXVt/mozboot/osx.py", line 185, in install_system_packages
  File "/var/folders/hc/8jjz1pjx2j7blyyyp9d1zdrh0000gn/T/tmpfZsXVt/mozboot/osx.py", line 446, in ensure_package_manager
  File "/var/folders/hc/8jjz1pjx2j7blyyyp9d1zdrh0000gn/T/tmpfZsXVt/mozboot/osx.py", line 495, in install_macports
Exception: We do not have a MacPorts install URL for your OS X version. You will need to install MacPorts manually.


MacPorts fails to install on Sierra:

Please choose a package manager you'd like:
1. Homebrew
2. MacPorts (Does not yet support bootstrapping Firefox for Android.)
Your choice:
2
Traceback (most recent call last):
  File "bootstrap.py", line 170, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 161, in main
    dasboot.bootstrap()
  File "/var/folders/py/3sfg3yq94mn89rqc8l44qv6h0000gn/T/tmp9WUDcn/mozboot/bootstrap.py", line 292, in bootstrap
    
  File "/var/folders/py/3sfg3yq94mn89rqc8l44qv6h0000gn/T/tmp9WUDcn/mozboot/osx.py", line 185, in install_system_packages
  File "/var/folders/py/3sfg3yq94mn89rqc8l44qv6h0000gn/T/tmp9WUDcn/mozboot/osx.py", line 446, in ensure_package_manager
  File "/var/folders/py/3sfg3yq94mn89rqc8l44qv6h0000gn/T/tmp9WUDcn/mozboot/osx.py", line 495, in install_macports
Exception: We do not have a MacPorts install URL for your OS X version. You will need to install MacPorts manually.


Additionally, python/mozboot/mozboot/osx.py installs an older version (2.3.4) of MacPorts instead of the current version (2.4.2).


Expected results:

Install the current version (2.4.2) on all supported Mac OS X versions including High Sierra and Sierra.
(Assignee)

Updated

28 days ago
Component: Untriaged → Build Config
OS: Unspecified → Mac OS X
Product: Firefox → Core
Hardware: Unspecified → x86_64
Comment hidden (mozreview-request)
(Assignee)

Comment 2

28 days ago
Updated to include MacPorts for Sierra (10.12) and High Sierra and to use the latest version (2.4.2) of MacPorts for all Mac OS versions.

Also removed unused variable MACPORTS_CLANG_PACKAGE as well as included correct path (/opt/local/bin) to 'port' command in the error message PACKAGE_MANAGER_BIN_MISSING.

Tested on both Sierra and High Sierra and confirmed the installation works now:

Please choose the version of Firefox you want to build:
1. Firefox for Desktop Artifact Mode
2. Firefox for Desktop
3. Firefox for Android Artifact Mode
4. Firefox for Android
Your choice: 2

It seems you don't have any supported package manager installed.


Please choose a package manager you'd like:
1. Homebrew
2. MacPorts (Does not yet support bootstrapping Firefox for Android.)
Your choice:
2

We will install the MacPorts package manager to install required packages.

You will be prompted to install MacPorts with its default settings. If you
would prefer to do this manually, hit CTRL+c, install MacPorts yourself, ensure
"port" is in your $PATH, and relaunch bootstrap.

Executing as root: sudo installer -pkg /var/folders/hc/8jjz1pjx2j7blyyyp9d1zdrh0000gn/T/tmpsVraEg.pkg -target /
installer: Package name is MacPorts
installer: Upgrading at base path /
installer: The upgrade was successful.

A package manager is installed. However, your current shell does
not know where to find 'port' yet. You'll need to start a new shell
to pick up the environment changes so it can be found.

Please start a new shell or terminal window and run this
bootstrapper again.

If this problem persists, you will likely want to adjust your
shell's init script (e.g. ~/.bash_profile) to export a PATH
environment variable containing the location of your package
manager binary. e.g.

Homebrew:
    export PATH=/usr/local/bin:$PATH 

MacPorts: 
    export PATH=/opt/local/bin:$PATH
Attachment #8920917 - Flags: review?(gps)
Assignee: nobody → stevea1

Comment 3

28 days ago
mozreview-review
Comment on attachment 8920917 [details]
Bug 1410752 - MacPorts in bootstrap.py is out of date, and fails on Sierra and High Sierra

https://reviewboard.mozilla.org/r/191862/#review197270
Attachment #8920917 - Flags: review?(gps) → review+
Attachment #8920917 - Flags: review?(core-build-config-reviews)
Attachment #8920917 - Flags: review?(core-build-config-reviews)

Comment 4

28 days ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/671e63202d44
MacPorts in bootstrap.py is out of date, and fails on Sierra and High Sierra r=gps
https://hg.mozilla.org/mozilla-central/rev/671e63202d44
Status: UNCONFIRMED → RESOLVED
Last Resolved: 27 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.