1410766 - GPUProcessManager::SimulateDeviceReset() causes GetDXGIAdapter() nullptr

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Sotaro Ikeda [:sotaro OOO until July/21]]

I saw the following log when GPUProcessManager::SimulateDeviceReset() was called during GPU process was enabled on windows. It is because GetDXGIAdapter() returned nullptr.

 - [GFX1-]: Could not get a DXGI adapter

Comment 1

[Sotaro Ikeda [:sotaro OOO until July/21]]

GPUProcessManager::SimulateDeviceReset() calls GPUProcessManager::OnRemoteProcessDeviceReset(), but SimulateDeviceReset() does not trigger updating devices in GPU process.

  https://dxr.mozilla.org/mozilla-central/source/gfx/ipc/GPUProcessManager.cpp#418

Comment 2

[Sotaro Ikeda [:sotaro OOO until July/21]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> It is because GetDXGIAdapter() returned nullptr.
> 
>  - [GFX1-]: Could not get a DXGI adapter

DeviceManagerDx::GetDXGIAdapter() failed to create DXGIAdapter, since all fields of mDeviceStatus->adapter() were 0.

Comment 3

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Comment 4

[Sotaro Ikeda [:sotaro OOO until July/21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecbdf16d74f69c6d2a6bdc14fb472dcffe5fda46

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8920928 [details] [diff] [review]
patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Review of attachment 8920928 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/PGPU.ipdl
@@ +77,5 @@
>    async RemoveLayerTreeIdMapping(LayerTreeIdMapping mapping);
>  
>    // Request the current DeviceStatus from the GPU process. This blocks until
>    // one is available (i.e., Init has completed).
> +  sync GetDeviceStatus(bool reacquireDevices) returns (GPUDeviceData status);

The functionality seems fine, but please add it in a new message instead of using GetDeviceStatus.

Comment 6

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Comment 7

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Comment 8

[Sotaro Ikeda [:sotaro OOO until July/21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b78226433abda109524aec5e2d48afcb5db60861

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8922141 [details] [diff] [review]
patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Review of attachment 8922141 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6eac731d5c33
Re-acquireDevices in gpu process when SimulateDeviceReset() is called r=dvander

Comment 11

[Attila Craciun [:arny]]

Backed out 1 changesets (bug 1410766) for failing Reftest in reftest/tests/layout/reftests/bugs/409084-1a.html r=backout 

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f573aaf7650829998fa393ccf788e9c04b4d3c2

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6eac731d5c33a24ef8d69a410554f201ab21a9ab&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Pretty sure the backout was incorrect.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=osx%20reftest&group_state=expanded&fromchange=92767404525aaee96990e37309cb2791fa3d1911&tochange=4f573aaf7650829998fa393ccf788e9c04b4d3c2

The reftest failure happens on the previous push as well but because of coalescing the reftest didn't run on that push until I backfilled it. I triggered the reftest job on the backout push as well so let's see if it persists.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/817727beee91
Re-acquireDevices in gpu process when SimulateDeviceReset() is called r=dvander

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry about that, relanded that push and backed out bug 1411860 and bug 1411886 from the previous push instead.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for leak - only on Windows 10?

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d02c88c7ba1d210364d296162f3ac2740672c4

See e.g. https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e863dc231d0095d0cc7bc1ddbf83a51c6958c343&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=139970845&repo=mozilla-inbound

12:38:42     INFO - TEST-PASS | leakcheck | default process: no leaks detected!
12:38:42     INFO - 
12:38:42     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, gpu process 5176
12:38:42     INFO - 
12:38:42     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
12:38:42     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
12:38:42     INFO -    0 |TOTAL                                 |       22      512|  949963        8|
12:38:42     INFO -   25 |DeviceAttachmentsD3D11                |      336      336|       1        1|
12:38:42     INFO -  112 |SyncObjectHost                        |       16       16|       3        1|
12:38:42     INFO -  120 |TextureHost                           |       40       40|     189        1|
12:38:42     INFO -  123 |TextureSource                         |       32       64|     827        2|
12:38:42     INFO -  124 |TextureSourceProvider                 |       40       40|       6        1|
12:38:42     INFO -  162 |nsTArray_base                         |        8       16|  133223        2|
12:38:42     INFO - 
12:38:42     INFO - nsTraceRefcnt::DumpStatistics: 169 entries
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 1 DeviceAttachmentsD3D11
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 1 SyncObjectHost
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 1 TextureHost
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 2 TextureSource
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 1 TextureSourceProvider
12:38:42     INFO - TEST-INFO | leakcheck | gpu process: leaked 2 nsTArray_base
12:38:42    ERROR - TEST-UNEXPECTED-FAIL | leakcheck | gpu process: 512 bytes leaked (DeviceAttachmentsD3D11, SyncObjectHost, TextureHost, TextureSource, TextureSourceProvider, ...)
12:38:42     INFO - 
12:38:42     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 2804
12:38:42     INFO - 
12:38:42     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
12:38:42     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
12:38:42     INFO -    0 |TOTAL                                 |       51       20|   42290        2|
12:38:42     INFO -  488 |nsStringBuffer                        |       12       12|   15663        1|
12:38:42     INFO -  524 |nsTArray_base                         |        8        8|    7978        1|
12:38:42     INFO - 
12:38:42     INFO - nsTraceRefcnt::DumpStatistics: 573 entries
12:38:42     INFO - TEST-INFO | leakcheck | tab process: leaked 1 nsStringBuffer
12:38:42     INFO - TEST-INFO | leakcheck | tab process: leaked 1 nsTArray_base
12:38:42  WARNING - leakcheck | tab process: 20 bytes leaked (nsStringBuffer, nsTArray_base)

Comment 16

[Sotaro Ikeda [:sotaro OOO until July/21]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #15)
> Backed out for leak - only on Windows 10?

Thanks. I am going to look into the leak.

Comment 17

[Sotaro Ikeda [:sotaro OOO until July/21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f8985a6f91ba3f1c05c22c6286ecdb4147f8672&selectedJob=141651195

With current m-c.

Comment 18

[Sotaro Ikeda [:sotaro OOO until July/21]]

Attachment: patch - Re-acquireDevices in gpu process when SimulateDeviceReset() is called

Fixed leak.

Comment 19

[Sotaro Ikeda [:sotaro OOO until July/21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad148f90327220e8c9331911d16b7c63c29c771e

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a2ae162869
Re-acquireDevices in gpu process when SimulateDeviceReset() is called r=dvander

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a5a2ae162869