Closed Bug 1410769 Opened 2 years ago Closed 2 years ago

Use SHA-1 signing when MAR_OLD_FORMAT is set.

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(1 file)

There is an option to allow generation of MAR files that are understood by pre-LZMA/SHA384 updaters. But it currently only change the compression format, not the signature format.
Comment on attachment 8920935 [details]
Bug 1410769: Use SHA-1 signing when MAR_OLD_FORMAT is set;

https://reviewboard.mozilla.org/r/191876/#review197346

I'm fine with this but these files need a build peer to review them nowadays.
Attachment #8920935 - Flags: review?(robert.strong.bugs) → review+
Attachment #8920935 - Flags: review?(core-build-config-reviews)
Comment on attachment 8920935 [details]
Bug 1410769: Use SHA-1 signing when MAR_OLD_FORMAT is set;

https://reviewboard.mozilla.org/r/191876/#review197410

I'm fine with this, although I'm not 100% sure that flag will make it to the relevant Makefile.

::: tools/update-packaging/Makefile.in:46
(Diff revision 1)
>  # We can't use sha2signcode on mar files
>  MOZ_EXTERNAL_SIGNING_FORMAT := $(filter-out sha2signcode,$(MOZ_EXTERNAL_SIGNING_FORMAT))
>  MOZ_EXTERNAL_SIGNING_FORMAT := mar $(MOZ_EXTERNAL_SIGNING_FORMAT)
>  endif
>  
> +ifdef MAR_OLD_FORMAT

nit: I have a mild preference for making the "normal path" come first.
Attachment #8920935 - Flags: review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/26444ee0baf1
Use SHA-1 signing when MAR_OLD_FORMAT is set; r=nalexander,rstrong
https://hg.mozilla.org/mozilla-central/rev/26444ee0baf1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.