1410790 - Add more assertion in CustomElementData::SetCustomElementDefinition and GetCustomElementDefinition to ensure that we only set CustomElementDefinition on a custom element which is "custom"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Edgar Chen [:edgar]]

This is a follow-up of bug 1392970. Since we only set CustomElementDefinition on a custom element which is "custom", we could add more assertion to ensure that.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d9c8b96ae1d62484d95ffcb5b0b8b03c3f81c85

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8920976 [details] [diff] [review]
Patch, v1

Review of attachment 8920976 [details] [diff] [review]:
-----------------------------------------------------------------

This patch does following things,
- Move mCustomElementDefinition to private member of CustomElementData.
- Add assertion to ensure that we set CustomElementDefinition when the state in CustomElementData is "custom".
- Add assertion to ensure that the type of CustomElementDefinition should match with the element.
- Do sanity check in GetCustomElementDefinition().

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8920976 [details] [diff] [review]
Patch, v1

>+CustomElementData::Traverse(nsCycleCollectionTraversalCallback &cb) const
Nit, nsCycleCollectionTraversalCallback& aCb

>+  void Traverse(nsCycleCollectionTraversalCallback &cb) const;
same here

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v2, r=smaug

Address review comment #3.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fda6993fe732
Add more assertion in CustomElementData::SetCustomElementDefinition and GetCustomElementDefinition; r=smaug

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fda6993fe732