1410861 - Implement AES-GCM unwrap of ECDSA keys for WebCrypto API

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, enhancement, P3)

Description

[lakano]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171019140425

Steps to reproduce:

On the well known Live API Table ( https://diafygi.github.io/webcrypto-examples/ ) we could see we can wrap a ECDSA key with AES-GCM but can't unwrap it. 
By the way, it's the same for ECDH algorithm.


Actual results:

Can't use unwrapKey() for ECDSA


Expected results:

Nothing

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Tim, can you weigh in?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Seems like that's missing. Will happily accept any patches :)

Comment 3

[Christoph Walcher]

Attachment: Bug 1410861 - Support for `unwrapKey` of ECDH/ECDSA keys

Comment 4

[Christoph Walcher]

As mentioned in phab, I don't have access to the try server. So I think you have to do this.

Comment 5

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Ok. If you want to keep submitting patches, I recommend you get try access so you can test your changes out before landing them: https://wiki.mozilla.org/ReleaseEngineering/TryServer#Getting_access_to_the_Try_Server

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2521231284c
Support for `unwrapKey` of ECDH/ECDSA keys r=keeler

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out changeset e2521231284c (bug 1410861) for wpt failures in test_wrapKey_unwrapKey.https.html.
https://hg.mozilla.org/integration/autoland/rev/dfad156f90efce51d3b53d2a8af295432bd5ced0

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=173d7b5c514afe2827548790780c79b863cf9c0d&selectedTaskRun=ASgYC18NQSGZu3Em8nMkZA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=330296303&repo=autoland&lineNumber=1952

Comment 8

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Looks like there are some tests in https://searchfox.org/mozilla-central/source/testing/web-platform/meta/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https.html.ini that are passing now. I believe you can remove the corresponding failure entries - e.g.:

  [Can wrap and unwrap ECDH public key keys using spki and AES-CTR]
    expected: FAIL

Comment 9

[Christoph Walcher]

Attachment: Bug 1410861 - Support for `unwrapKey` of ECDH/ECDSA keys

Depends on D97711

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/503a3d1a480f
Support for `unwrapKey` of ECDH/ECDSA keys r=keeler

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/503a3d1a480f