1410886 - Update test262

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[André Bargull [:anba]]

Update test262 to fix intermittent time-outs (bug 1356109).

Comment 1

[André Bargull [:anba]]

Attachment: bug1410886-part1-exclude-optional-catch.patch

Adds "optional-catch-binding" to the list of unsupported features.

Comment 2

[André Bargull [:anba]]

Attachment: bug1410886-part2-update-test262.patch

Updated test262 files.

Comment 3

[André Bargull [:anba]]

Attachment: bug1410886-part3-update-skip-list.patch

Updates the skip list and removes duplicate excludes.

Now that test262 is more strict about the features flag, we don't need to manually exclude tests with unsupported features in jstests.list, but instead can rely on automatically marking the tests as unsupported during the test262 import.

Comment 4

[André Bargull [:anba]]

Note to self: Part 3 needs to be updated now that bug 1410194 has landed.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8921038 [details] [diff] [review]
bug1410886-part1-exclude-optional-catch.patch

Review of attachment 8921038 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/test262-update.py
@@ +23,4 @@
>                              "BigInt",
>                              "class-fields",
>                              "Promise.prototype.finally",
> +                            "optional-catch-binding",

This is missing the IsHTMLDDA feature in the latest import -- I think -- but that's only because I hadn't landed bug 1410194 yet, and given I did that just now, I think you're good.

This unsupported feature has a bug and a patch that we should probably push on sooner rather than later.

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 8921039 [details] [diff] [review]
bug1410886-part2-update-test262.patch

Review of attachment 8921039 [details] [diff] [review]:
-----------------------------------------------------------------

Gonna assume this is just a flat run without any changes.

Comment 7

[Jeff Walden [:Waldo]]

Comment on attachment 8921042 [details] [diff] [review]
bug1410886-part3-update-skip-list.patch

Review of attachment 8921042 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/jstests.list
@@ +472,5 @@
>  
> +# https://bugzilla.mozilla.org/show_bug.cgi?id=1410194
> +skip script test262/annexB/language/statements/for-await-of/iterator-close-return-emulates-undefined-throws-when-called.js
> +skip script test262/annexB/language/expressions/yield/star-iterable-return-emulates-undefined-throws-when-called.js
> +skip script test262/annexB/language/statements/for-of/iterator-close-return-emulates-undefined-throws-when-called.js

Oh, you were taking this approach.  Remove this now.

Comment 8

[André Bargull [:anba]]

(In reply to Jeff Walden [:Waldo] (I'm baaaaaaack...) from comment #7)
> Comment on attachment 8921042 [details] [diff] [review]
> bug1410886-part3-update-skip-list.patch
> 
> Review of attachment 8921042 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/tests/jstests.list
> @@ +472,5 @@
> >  
> > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1410194
> > +skip script test262/annexB/language/statements/for-await-of/iterator-close-return-emulates-undefined-throws-when-called.js
> > +skip script test262/annexB/language/expressions/yield/star-iterable-return-emulates-undefined-throws-when-called.js
> > +skip script test262/annexB/language/statements/for-of/iterator-close-return-emulates-undefined-throws-when-called.js
> 
> Oh, you were taking this approach.  Remove this now.

Yeah, I did that instead of adding IsHTMLDDA to the non-supported features list in test262-update.py, because I figured bug 1410194 will land soonish and it's slightly faster to remove four lines in jstests.list than running the import script. :-)

Comment 9

[André Bargull [:anba]]

(In reply to André Bargull [:anba] from comment #8)
> Yeah, I did that instead of adding IsHTMLDDA to the non-supported features
> list in test262-update.py, because I figured bug 1410194 will land soonish
> and it's slightly faster to remove four lines in jstests.list than running
> the import script. :-)

LOL, good thing I missed to check if bug 1410194 also updates the generated js/src/tests/test262/shell.js file, which it did not, so in the end I had to redo the update again. :-)

Comment 10

[André Bargull [:anba]]

Attachment: bug1410886-part2-update-test262.patch

Rerun the update script to regenerate js/src/tests/test262/shell.js per comment #9. Carrying r+.

Comment 11

[André Bargull [:anba]]

Attachment: bug1410886-part3-update-skip-list.patch

Remove exclusions for bug 1410194 per comment #8. Carrying r+.

Comment 12

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22de90c6d375a867b8fd77e903409b62de095c75

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a64b980ac0bc
Part 1: Add 'optional-catch-binding' to non-supported features. r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/8681fde5335f
Part 2: Update test262 files. rs=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/a56ed92679e6
Part 3: Update test262 skip list. r=Waldo

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a64b980ac0bc
https://hg.mozilla.org/mozilla-central/rev/8681fde5335f
https://hg.mozilla.org/mozilla-central/rev/a56ed92679e6