1410909 - automatic NSS/NSPR ABI checks are broken

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Kai Engert (:KaiE:)]

The ABI checks are broken.
Buildbot reports:

touch: cannot touch 'nss/automation/abi-check/expected-report-libfreebl3.so.txt': No such file or directory
hg/nss/automation/buildbot-slave/build.sh: line 268: nss/automation/abi-check/new-report-libfreebl3.so.txt: No such file or directory
diff: nss/automation/abi-check/expected-report-libfreebl3.so.txt: No such file or directory
diff: nss/automation/abi-check/new-report-libfreebl3.so.txt: No such file or directory


Unfortunately these error messags didn't result in a test failure.

The problem was apparently the use of relative paths in the abi-check commands, which didn't work for the current work directory.

I'll attach a patch to set that to absolute paths, and I'll add more checks to detect and report failures.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: patch v1

I'll request review after it works.

We don't have a try build environment for buildbot, the easiest is to check the new automation script in.

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 8921078 [details] [diff] [review]
patch v1

This patch works, it reports our one ABI change.

Franziskus, I've already checked this in. Would you like to do a review after-the-fact? Thanks

Comment 3

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8921078 [details] [diff] [review]
patch v1

Review of attachment 8921078 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

We should get this running on Taskcluster then we can use try.

Comment 4

[Kai Engert (:KaiE:)]

(In reply to Franziskus Kiefer [:fkiefer or :franziskus] from comment #3)
> We should get this running on Taskcluster then we can use try.

I still need buildbot for the FIPS and RHEL configurations that Mozilla doesn't test.

For abi-check on taskcluster we have bug 1367470 in the backlog.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: 1410909-ignore-whitespace.patch

I'd like to add another minor fix as part of this bug.

When I added additional whitelisting, by copy/pasting from buildbot output, I added an additional blank line, which caused the abi check to fail.

I suggest that we ignore all whitespace changes, including blank lines.

Comment 6

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8921911 [details] [diff] [review]
1410909-ignore-whitespace.patch

Review of attachment 8921911 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense

Comment 7

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/afd225fc78ee