automatic NSS/NSPR ABI checks are broken

RESOLVED FIXED in 3.34

Status

NSS
Test
RESOLVED FIXED
27 days ago
24 days ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

3.34
3.34

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

27 days ago
The ABI checks are broken.
Buildbot reports:

touch: cannot touch 'nss/automation/abi-check/expected-report-libfreebl3.so.txt': No such file or directory
hg/nss/automation/buildbot-slave/build.sh: line 268: nss/automation/abi-check/new-report-libfreebl3.so.txt: No such file or directory
diff: nss/automation/abi-check/expected-report-libfreebl3.so.txt: No such file or directory
diff: nss/automation/abi-check/new-report-libfreebl3.so.txt: No such file or directory


Unfortunately these error messags didn't result in a test failure.

The problem was apparently the use of relative paths in the abi-check commands, which didn't work for the current work directory.

I'll attach a patch to set that to absolute paths, and I'll add more checks to detect and report failures.
(Assignee)

Comment 1

27 days ago
Created attachment 8921078 [details] [diff] [review]
patch v1

I'll request review after it works.

We don't have a try build environment for buildbot, the easiest is to check the new automation script in.
Assignee: nobody → kaie
Attachment #8921078 - Flags: review?
(Assignee)

Comment 2

27 days ago
Comment on attachment 8921078 [details] [diff] [review]
patch v1

This patch works, it reports our one ABI change.

Franziskus, I've already checked this in. Would you like to do a review after-the-fact? Thanks
Attachment #8921078 - Flags: review? → review?(franziskuskiefer)
Comment on attachment 8921078 [details] [diff] [review]
patch v1

Review of attachment 8921078 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

We should get this running on Taskcluster then we can use try.
Attachment #8921078 - Flags: review?(franziskuskiefer) → review+
(Assignee)

Comment 4

27 days ago
(In reply to Franziskus Kiefer [:fkiefer or :franziskus] from comment #3)
> We should get this running on Taskcluster then we can use try.

I still need buildbot for the FIPS and RHEL configurations that Mozilla doesn't test.

For abi-check on taskcluster we have bug 1367470 in the backlog.
(Assignee)

Updated

27 days ago
Status: NEW → RESOLVED
Last Resolved: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 3.34
(Assignee)

Comment 5

25 days ago
Created attachment 8921911 [details] [diff] [review]
1410909-ignore-whitespace.patch

I'd like to add another minor fix as part of this bug.

When I added additional whitelisting, by copy/pasting from buildbot output, I added an additional blank line, which caused the abi check to fail.

I suggest that we ignore all whitespace changes, including blank lines.
Attachment #8921911 - Flags: review?(franziskuskiefer)
Comment on attachment 8921911 [details] [diff] [review]
1410909-ignore-whitespace.patch

Review of attachment 8921911 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense
Attachment #8921911 - Flags: review?(franziskuskiefer) → review+
(Assignee)

Comment 7

24 days ago
https://hg.mozilla.org/projects/nss/rev/afd225fc78ee
You need to log in before you can comment on or make changes to this bug.