Content Blocker assert() performing lookUpContentRuleList

RESOLVED FIXED

Status

()

Firefox for iOS
General
P3
normal
RESOLVED FIXED
27 days ago
25 days ago

People

(Reporter: garvan, Assigned: garvan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0)

Details

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review | Splinter Review
(Assignee)

Description

27 days ago
Reported: https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/crashreport/b22be58e0b0bfe93096ba14fa1489532

The content blocker API has some undocumented areas, for instance what to do when a lookUpContentRuleList() returns a blank rule. That function should  return valid rules that were previously loaded into the WKWebView.
This is the first time we have hit this code path, could be due to an OS update an this behaves differently. The release build will just ignore the rule ATM.

However, knowing that this code path is hit, we should try re-install the rule.
(Assignee)

Updated

27 days ago
Assignee: nobody → gkeeley
tracking-fxios: ? → 10.0
Priority: -- → P3
(Assignee)

Comment 1

26 days ago
Created attachment 8921653 [details] [review]
Pull request

We have 2 reports of this assert() since ContentBlockers were added. Lets gather more info with Sentry.
Attachment #8921653 - Flags: review?(fpatel)

Updated

25 days ago
Attachment #8921653 - Flags: review?(fpatel) → review+
(Assignee)

Comment 2

25 days ago
on master and v10.x
Status: NEW → RESOLVED
Last Resolved: 25 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.