Status

()

enhancement
P3
normal
2 years ago
a year ago

People

(Reporter: gandalf, Unassigned)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

At the moment, the only fallbacking we do is from any locale to en-US.

It's hardcoded as:
 - locale we package fallback files for
 - locale we add to requested locales (bug 1410733)
 - locale we add to available locales (bug 1410731)

Instead, we should develop a dataset of locale fallback chains and then make it possible to retrieve it at runtime and build time.

My initial idea would be to:

 - get it as a .json file somewhere in `intl/locale/`
 - add python/mozbuild python command to retrieve a fallback for a given locale(s)
 - add LocaleService method to retrieve a fallback for a given locale(s)
 - switch the current uses to use the new API

The API could just do ['ab-CD', 'en-US'] unless an exception is listed in the new .json data structure.
(Reporter)

Updated

2 years ago
Blocks: 1365426
Priority: -- → P3
(Reporter)

Comment 1

a year ago
Axel, what do you think? In bug 1414390 I'm going to liberate us technically to store a list of locales as requested ones.

In this bug I'd like to consider, either in one bug, or split into two, a way to:

1) Add additional fallbacks to MOZ_CHROME_MULTILOCALE at build time
2) Add additional fallbacks to LocaleService::GetRequestedLocales at runtime

My current idea is sth like this:

a) in intl/locale/fallbacks.json we'd have sth like:

```
{
  "sr-RU": ["ru", "sr-SR"]
}
```

b) when, in the future, we get to build multilocale builds and someone builds:

MOZ_CHROME_MULTILOCALE="sr-RU, de, ru" ./mach package

we would look into the json file and extend the MOZ_CHROME_MULTILOCALE to "sr-RU, ru, sr-SR, de, en-US".

b) when someone is building a langpack with:

./mach build langpack-sr-RU

we would actually package ["sr-RU", "ru", "sr-SR", "en-US"]

c) at runtime, when someone calls GetRequestedLocales with `intl.locale.requested` set to "sr-RU,de,ru" we would return ["sr-RU", "ru", "sr-SR", "de", "en-US"]

Does it sound reasonable to you?
Flags: needinfo?(l10n)
I'd comment on build-time next year, mostly because I'm on PTO during/after Austin, and the conversation there might impact what we do big-picture-wise.

We could work on runtime now, probably, but I'm not sure it's worth it yet.

For now, it'd probably be good to get the actual dataset of locales that need specific fallback, so that we can make technical decisions based on practical need.
Flags: needinfo?(l10n)
(Reporter)

Comment 3

a year ago
Flod, Delphine - is gathering a list of locale fallbacks something you'd be interested in tackling?

I'd be mostly curious about locales that wouldn't want a direct ["ab-CD", "en-US"] fallback. For example, `en-IN` or `en-AU` may want `en-GB`, `es-MX` would probably want `es` etc.
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(francesco.lodolo)
I can help with this. I'll reach out and discuss what's the best way to gather this list.
Flags: needinfo?(lebedel.delphine)
I was thinking a possible plan would be to reach out to locale leaders from each locale we have on Pontoon, and gather locale fallback preferences this way. I can set up a simple survey and send that out - recommending to the locale leader to reach out to the wider l10n community (when applicable) to give input as well before voting.

I can just use something like the list of managers Flod had gathered from Pudelo times to quickly send something out (I don't believe it's changed much since then - but I can make sure to compare and fill in the gaps/changes when needed).

@flod, @zibi: how does that sound to you?
(hit send too soon)
For locales that we don't have on Pontoon (like en-IN or en-AU) I'm not quite sure though. Some seem "logical" and easy to guess, but I'm assuming it's not the case for all. I'll have to think that part through more :)
Is there a list of non-Pontoon locales that we know we're interested in getting this data for, maybe?
The survey sounds like a good idea to me, but I need to get a better idea of the actual ask first.

This locale fallback chain is for UI language, correct? If that's the case, I think we should only cover locales that are in our builds, both as keys in the JSON, and as values for each locale. Otherwise, I have no idea how we can collect this data.

For example, I don't expect to have:

  "sr-RU": ["ru", "sr-SR"]

because we don't support sr-RU or sr-SR in our builds. I would expect something like this for Fulah:

  "ff": ["fr"]

Resulting in a response ["ff", "fr", "en-US"]. The default is the key itself, the last is en-US (implicit).

I would also like to be able to strip regions when not strictly necessary. If I ask for "sr-SR", would it fall back automatically to "sr" if it's in the list?
Flags: needinfo?(francesco.lodolo)
(Reporter)

Updated

a year ago
See Also: → 1456388
You need to log in before you can comment on or make changes to this bug.