1410944 - Uninstaller doesn't remove redundant StartMenuInternet and RegisteredApplications keys

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P1)

Description

[Molly Howell (she/her) (mostly inactive)]

While investigating bug 1406169, it was found that some of the duplicate registry entries created by that bug do not get removed by the uninstaller. This makes it very difficult to clean up that bug's damage.

Specifically, it's possible that values called both "Firefox" and also "FIREFOX.EXE" can exist in {HKLM,HKCU}\Software\RegisteredApplications, pointing to the same Capabilities key, and only the first value would currently be uninstalled.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1410944 - Support uninstalling a duplicated registry entry we might have erroneously created.

Review commit: https://reviewboard.mozilla.org/r/192146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192146/

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8921156 [details]
Bug 1410944 - Support uninstalling a duplicated registry entry we might have erroneously created.

https://reviewboard.mozilla.org/r/192146/#review197428

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7361a04cfd7c
Support uninstalling a duplicated registry entry we might have erroneously created. r=agashlin

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7361a04cfd7c

Comment 5

[joaopaulo1511]

Please don't forget "HKLM\Software\WOW6432Node\RegisteredApplications" on Windows 64 bit versions.

Also, the duplicated registry entries on HKCU and HKLM versions of Software\RegisteredApplications on Windows 10 version 1709 systems make it appear **four** Firefox entries inside Settings, Apps, Default Apps, Set default apps (I don't know if it written this way in English, my Windows is in Brazilian Portuguese).