Closed Bug 1410979 Opened 7 years ago Closed 5 years ago

Stop reloading the page on param changes like push, revision, etc.

Categories

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

Details

We shouldn't need to reload the entire web page when the user changes things like ``revision``, ``author``, ``tochange``, etc..  We should be able to simply empty our data held in ``resultset_store`` and reload the correct data without a full page reload.

It's simply a matter of being sure to clean things up thoroughly so we don't leak memory on the change.
We DO intend to move from AngularJS to ReactJS in the coming months, so this work may be better waiting till we make that transition.  Though it certainly could be done sooner.  And that may make the ReactJS transition easier.  It's hard to say, but worth considering.
Summary: Stop reloading the page on selections → Stop reloading the page on param changes like push, revision, etc.

This is now happening as a result of moving the "push" management to Redux. Will mark this as fixed when that lands.

Assignee: nobody → cdawson
Priority: -- → P1

With the latest fix to convert pushes to Redux, this is now fixed.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.