Closed Bug 1410985 Opened 7 years ago Closed 7 years ago

No Pocket/Library animation in Nightly

Categories

(Firefox :: Pocket, defect)

58 Branch
Unspecified
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: madhava, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(1 file)

Hi all -

In today's nightly (Oct 23 - though maybe it's been like this for longer) I don't get the Pocket-icon-falls-into-the-library-icon animation when adding things to Pocket.

I'm adding to pocket through the item in the Page Actions Menu. I have the Library icon in default position in the toolbar.
I'm unable to reproduce this bug on latest Nightly (10/23) on Windows 10.

Note that you will need to be signed in to Pocket and wait for the Pocket panel to say "Saved to Pocket" (or similar language) before closing the Pocket popup. Only then will the page be saved to Pocket and only then will we display the "Pocket-icon-falls-into-the-library-icon animation.
Flags: needinfo?(madhava)
Weird.

I'm on MacOS, latest Nightly (confirmed). I'm signed into Pocket. I click "Save Page to Pocket" and wait for the pocket save confirmation doorhanger to disappear again. No animation on the Library.

The page I'm trying to save to Pocket is indeed saved to pocket when I go and view my pocket list.
Flags: needinfo?(madhava)
Summary: No Pocket/Library animation in Nightly → (OSX) No Pocket/Library animation in Nightly
Stefan, can you test this on OSX and find when this regressed (using mozregression)?

http://mozilla.github.io/mozregression/
Flags: needinfo?(stefan.georgiev)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13 rv:58.0) Gecko/20100101 Firefox/58.0 (20171024100135)

Could you let us know on what version of Mac OS you see this issue and what is the value for toolkit.cosmeticAnimations.enabled in about:config? 

I`m testing with latest Nightly from 10/24 using Mac OS 10.13 (High Sierra) and I could not managed to reproduce it.
I have tested it on Windows 10 x64 and Ubuntu 16.04 and still could not reproduce it.

Here is a short video showing the animation works correctly for me.

https://www.dropbox.com/s/jmrt1xypm64ytco/Save%20to%20Pocket%2010.13%20OSX.mov?dl=0
I'm on macOS Sierra Version 10.12.3. toolkit.cosmeticAnimations.enabled is set to true.
One difference between my situation and the video in Comment 5 is that, in my case, the Pocket button is not shown in the URL bar -- it's in the Page Actions menu (the ...).

Aha! When I add the pocket button to the URL bar (by right clicking and selection "Add to Address Bar"), I _do_ get the animation when using that button.

This animation should work even if I'm adding to Pocket from the Page Actions menu. This had been working before.
Yeah, I can reproduce it now. Thanks! We should still see if this is a recent regression.
Summary: (OSX) No Pocket/Library animation in Nightly → No Pocket/Library animation in Nightly
Assignee: nobody → jaws
Status: NEW → ASSIGNED
I have used mozregression to find a regression range. Here are my findings:

Last good revision: 5f336a4ae6ce6274feccb2054b1bd6f8dd0fb9ef
First bad revision: 5bcbac52b473e2385d56c16c13c623d7d537b893
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5f336a4ae6ce6274feccb2054b1bd6f8dd0fb9ef&tochange=5bcbac52b473e2385d56c16c13c623d7d537b893
Flags: needinfo?(stefan.georgiev)
Blocks: 1387141
Version: 57 Branch → 58 Branch
Comment on attachment 8921648 [details]
Bug 1410985 - Run the pocket-library animation if the item was added, regardless of the position of the Pocket button.

https://reviewboard.mozilla.org/r/192642/#review197864

Ah, thanks Jared!
Attachment #8921648 - Flags: review?(adw) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/841b4cc3ecce
Run the pocket-library animation if the item was added, regardless of the position of the Pocket button. r=adw
https://hg.mozilla.org/mozilla-central/rev/841b4cc3ecce
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
QA Whiteboard: [good first verify]
I have Reproduced this bug with Firefox aurora Version 58.0b12 on Windows 7,(32-bit)

Status: Fixed & Verified 

Useragent: Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0 
BuildID: 20171218174357

[testday-20171222]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: