Closed Bug 1411005 Opened 2 years ago Closed 2 years ago

Update Harfbuzz to 1.6.3

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: tjr, Assigned: RyanVM)

References

Details

(Whiteboard: [third-party-lib-audit])

Attachments

(1 file, 2 obsolete files)

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

Harfbuzz is currently at version 1.6.0 in mozilla-central, and the latest version of the library released is 1.6.1. 

I fetched the latest version of the library from https://github.com/behdad/harfbuzz/.
Assignee: nobody → ryanvm
No longer depends on: 1393375
No, let's not take this -- 1.6.1 has a serious bug. 1.6.2 should be out any time now....
Summary: Update Harfbuzz to 1.6.1 → Update Harfbuzz to 1.6.2
Comment on attachment 8921204 [details] [diff] [review]
update harfbuzz to version 1.6.1

Roger that.
Attachment #8921204 - Attachment is obsolete: true
Attachment #8921204 - Flags: review?(jfkthame)
Attached patch update harfbuzz to version 1.6.2 (obsolete) — Splinter Review
This time with feeling.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f94aae136e63d15a86fccb73728939b5db8dba1

I'll obviously wait until the Try push looks good before pushing in the event that this gets r+ in the mean time.
Attachment #8921210 - Flags: review?(jfkthame)
Flags: needinfo?(jfkthame)
Attachment #8921210 - Flags: review?(jfkthame)
Yes, I can reproduce failures locally with this patch. Not yet sure what's broken but something is clearly amiss. Will try to investigate...
Flags: needinfo?(jfkthame)
OK, I've got a couple of PRs open upstream:

    https://github.com/behdad/harfbuzz/pull/582
    https://github.com/behdad/harfbuzz/pull/583

We shouldn't take the new harfbuzz version until these are resolved. (I expect there'll be a 1.6.3 sometime soon...)
Summary: Update Harfbuzz to 1.6.2 → Update Harfbuzz to 1.6.3
Comment on attachment 8922484 [details] [diff] [review]
update harfbuzz to version 1.6.3

Review of attachment 8922484 [details] [diff] [review]:
-----------------------------------------------------------------

Third time's a charm.
Attachment #8922484 - Flags: review?(jfkthame) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f095ae94d8
Update Harfbuzz to version 1.6.3. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/e7f095ae94d8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.