1411056 - SVGSVGElement: unnecessary parentheses in declaration of 'NS_NewSVGSVGElement'

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In file included from /root/firefox-gcc-last/image/SVGDocumentWrapper.cpp:27:0,
                  from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/image/Unified_cpp_image1.cpp:38:
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/SVGSVGElement.h:85:19: error: unnecessary parentheses in declaration of 'NS_NewSVGSVGElement' [-Werror=parentheses]
    friend nsresult (::NS_NewSVGSVGElement(nsIContent **aResult,

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1411056 - SVGSVGElement: Remove unnecessary parentheses in declaration of 'NS_NewSVGSVGElement'

Review commit: https://reviewboard.mozilla.org/r/192244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192244/

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8921237 [details]
Bug 1411056 - SVGSVGElement: Remove unnecessary parentheses in declaration of 'NS_NewSVGSVGElement'

https://reviewboard.mozilla.org/r/192244/#review197426

r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be03517460fd
SVGSVGElement: Remove unnecessary parentheses in declaration of 'NS_NewSVGSVGElement' r=dholbert

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for build bustage at dom/SVGSVGElement.h:87:

https://hg.mozilla.org/integration/autoland/rev/01c28e18b63c00989775445dbeec6adc697b17b7

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=be03517460fdd4a409ef6b01669f861a27aa1d3b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=139100911&repo=autoland

[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -  In file included from /builds/worker/workspace/build/src/image/SVGDocumentWrapper.cpp:27:0,
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -                   from /builds/worker/workspace/build/src/obj-firefox/image/Unified_cpp_image1.cpp:38:
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/SVGSVGElement.h:87:77: error: 'enum class nsresult' is not a class or a namespace
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -                                           mozilla::dom::FromParser aFromParser);
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -                                                                               ^
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/SVGSVGElement.h:87:77: error: ISO C++ forbids declaration of 'NS_NewSVGSVGElement' with no type [-fpermissive]
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1072: recipe for target 'Unified_cpp_image1.o' failed
[task 2017-10-24T06:14:15.446Z] 06:14:15     INFO -  gmake[5]: *** [Unified_cpp_image1.o] Error 1

Comment 5

[Andi [:andi]]

This should not land since it's a bug in gcc. I've forwarded a gcc bug on this matter.

Comment 6

[Andi [:andi]]

As pe comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1411056#c5

Comment 7

[Daniel Holbert [:dholbert]]

Thanks! Calling this INVALID then, since it's not actually a bug in Mozilla code.