1411073 - aom import cleanup

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Ralph Giles (:rillian)]

Some patches for the aom vendoring.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1411073 - av1: Clean up duplicate filenames check.

Check for filenames which differ only by .asm vs .c filename
extensions when importing a new version of the libaom reference
implementation of the av1 video codec.

These confuse our build system as well. Also remove the obsolete
vp8 and vp9 search directories, which generate warnings from 'find'.

Review commit: https://reviewboard.mozilla.org/r/192268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192268/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1411073 - av1: Log the output of generate_sources_mozbuild.sh.

By default, run_process() eats the output of the child process,
which means when it fails we get an exception about the return
code, but none of the error messages the script printed, with
makes the cause of failure opaque.

Resolve this by passing a log_name parameter, which will cause
the default line_handler to pass all lines of output to the
local logging instance, by default at the INFO level.

Review commit: https://reviewboard.mozilla.org/r/192270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192270/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197448

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197842

::: commit-message-9056f:7
(Diff revision 1)
> +
> +Check for filenames which differ only by .asm vs .c filename
> +extensions when importing a new version of the libaom reference
> +implementation of the av1 video codec.
> +
> +These confuse our build system as well. Also remove the obsolete

Should we support compiling the .asm / .c files into different .o filenames in the build system?

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197842

> Should we support compiling the .asm / .c files into different .o filenames in the build system?

That would be the best fix, I think. Do you know how to do that?

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8921256 [details]
Bug 1411073 - av1: Log the output of generate_sources_mozbuild.sh.

https://reviewboard.mozilla.org/r/192270/#review197846

Comment 7

[Michael Shal [:mshal]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #5)
> > Should we support compiling the .asm / .c files into different .o filenames in the build system?
> 
> That would be the best fix, I think. Do you know how to do that?

It may be as simple as changing ASOBJS: https://dxr.mozilla.org/mozilla-central/source/config/rules.mk#220

(like changing the suffix from .$(OBJ_SUFFIX) to .asm.$(OBJ_SUFFIX) or some such). I'm not sure offhand what other side effects that may have, though.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/776a7eb4c87a
av1: Clean up duplicate filenames check. r=kinetik,mshal
https://hg.mozilla.org/integration/autoland/rev/617173b7edbd
av1: Log the output of generate_sources_mozbuild.sh. r=mshal

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/776a7eb4c87a
https://hg.mozilla.org/mozilla-central/rev/617173b7edbd