Closed Bug 1411073 Opened 4 years ago Closed 4 years ago

aom import cleanup

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(2 files)

Some patches for the aom vendoring.
Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197448
Attachment #8921255 - Flags: review?(kinetik) → review+
Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197842

::: commit-message-9056f:7
(Diff revision 1)
> +
> +Check for filenames which differ only by .asm vs .c filename
> +extensions when importing a new version of the libaom reference
> +implementation of the av1 video codec.
> +
> +These confuse our build system as well. Also remove the obsolete

Should we support compiling the .asm / .c files into different .o filenames in the build system?
Attachment #8921255 - Flags: review+
Comment on attachment 8921255 [details]
Bug 1411073 - av1: Clean up duplicate filenames check.

https://reviewboard.mozilla.org/r/192268/#review197842

> Should we support compiling the .asm / .c files into different .o filenames in the build system?

That would be the best fix, I think. Do you know how to do that?
Attachment #8921255 - Flags: review?(core-build-config-reviews)
Attachment #8921256 - Flags: review?(core-build-config-reviews) → review?(mshal)
Comment on attachment 8921256 [details]
Bug 1411073 - av1: Log the output of generate_sources_mozbuild.sh.

https://reviewboard.mozilla.org/r/192270/#review197846
Attachment #8921256 - Flags: review?(mshal) → review+
(In reply to Ralph Giles (:rillian) | needinfo me from comment #5)
> > Should we support compiling the .asm / .c files into different .o filenames in the build system?
> 
> That would be the best fix, I think. Do you know how to do that?

It may be as simple as changing ASOBJS: https://dxr.mozilla.org/mozilla-central/source/config/rules.mk#220

(like changing the suffix from .$(OBJ_SUFFIX) to .asm.$(OBJ_SUFFIX) or some such). I'm not sure offhand what other side effects that may have, though.
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/776a7eb4c87a
av1: Clean up duplicate filenames check. r=kinetik,mshal
https://hg.mozilla.org/integration/autoland/rev/617173b7edbd
av1: Log the output of generate_sources_mozbuild.sh. r=mshal
https://hg.mozilla.org/mozilla-central/rev/776a7eb4c87a
https://hg.mozilla.org/mozilla-central/rev/617173b7edbd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.