1411123 - Re-enabling an extension that overrides the home page does not update about:preferences correctly

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P3)

Description

[Bob Silverberg [:bsilverberg]]

Attachment: manifest.json for the STR

If you install an extension that overrides the home page, then disable it, then restart Firefox, then re-enable it, the home page is overridden but about:preferences doesn't include the expected controls around the home page.

STR:

1. Install an extenion which overrides the home page from a file via about:addons.
2. Check about:preferences. All appears as expected: home page is overidden and user can not edit it without disabling the extension.
3. Disable the extension.
4. Check about:preferences. All appears as expected: home page is back to the default and user can edit it.
5. Shut down Firefox normally.
6. Start Firefox.
7. Go to about:addons and enable the extension.
8. Check about:preferences. It does not appear as expected: The home page value is overidden, but it is editable by the user and the message for disabling the extension is not present.

I am attaching a manifest.json file that can be used to generate an extension to reproduce this issue.

Note that we tested this on 57 and Nightly and it reproduces on Nightly but not on 57.

Comment 1

[Mark Striemer [:mstriemer]]

I think this is happening because ExtensionSettingsStore.addSetting() only updates the value of the setting. If it is disabled, it stays disabled. Calling addSetting() should likely enable the setting.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1411123 - Enable settings when set in ExtensionSettingsStore

Review commit: https://reviewboard.mozilla.org/r/215758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215758/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8945628 [details]
Bug 1411123 - Enable settings when set in ExtensionSettingsStore

https://reviewboard.mozilla.org/r/215758/#review221504

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e7974162770
Enable settings when set in ExtensionSettingsStore r=aswan

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8e7974162770

Comment 6

[marius.santa]

Attachment: reanable extension.gif

I was able to reproduce this bug in Firefox 58.0a1(20171023220222).
Retested and verified the bug in Firefox 60.0a1(20180205100240) on Windows 10 64Bit and Mac OS  X 10.13.2.

Comment 7

[Julien Cristau [:jcristau]]

should we get this in 59?

Comment 8

[Julien Cristau [:jcristau]]

Guess not, we're now a week away from RC.

Comment 9

[Alex J]

Will a fix go in 60? Able to reproduce.

Comment 10

[Andrew Swan [:aswan]]

This is fixed in 60, are you able to reproduce it in Firefox Beta?
If so, please spell out the exact steps you took.

Comment 11

[Alex J]

Seeing it fixed in FF60 beta, thanks!