1411129 - Rename MayBeAsynchronouslyScrolled

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Mats Palmgren (inactive)]

Minor nit on bug 1404181:
"Maybe" is one word so the "B" shouldn't be capitalized.
Also, there is another method named IsMaybeScrollingActive just below it:
http://searchfox.org/mozilla-central/rev/d30462037ffea383e74c42542c820cf65b2b144e/layout/generic/nsGfxScrollFrame.h#358
so perhaps we should rename it IsMaybeAsynchronouslyScrolled
to follow the existing naming convention?

Comment 1

[abhinavdv]

I would like to work on this bug.Can you please assign this bug to me?
This being my second bug I might require a little help. can you kindly please help me?

Comment 2

[Mats Palmgren (inactive)]

This URL has documentation on how to create a patch:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code
Good luck! :-)

Comment 3

[abhinavdv]

Attachment: Bug-1411129.patch

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8944351 [details] [diff] [review]
Bug-1411129.patch

It seems my naming suggestion above was a bit unclear, sorry.
What I meant was that we should add the prefix "Is" to MaybeAsynchronouslyScrolled too, so that it matches "Is" in IsMaybeScrollingActive.  (Not that we should rename
IsMaybeScrollingActive.)

In other words, please rename MayBeAsynchronouslyScrolled to
IsMaybeAsynchronouslyScrolled and nothing else.

Comment 5

[abhinavdv]

Attachment: bug-1411129v2.patch

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8944654 [details] [diff] [review]
bug-1411129v2.patch

Looks good so far, but we need to change all places in same way:
https://searchfox.org/mozilla-central/search?q=MaybeAsynchronouslyScrolled

Comment 7

[abhinavdv]

Attachment: bug-1411129v3.patch

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 8946230 [details] [diff] [review]
bug-1411129v3.patch

This looks good, thanks.  I landed it with an updated commit message:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93bc1205d13607ff8c2fc6c6e9703f9f392f1f8e

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/93bc1205d136