1411142 - Resolve enum-compare warnings exposed by MinGW build

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I think there's a few of these, but here's the first:

> /builds/worker/workspace/build/src/dom/plugins/ipc/hangui/MiniShmBase.h:303:23: error: comparison between 'enum mozilla::plugins::MiniShmBase::MiniShmInit::identifier_t' and 'enum mozilla::plugins::MiniShmBase::ReservedCodes' [-Werror=enum-compare]
>          T::identifier > RESERVED_CODE_LAST) {
>          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1411142 Cast enums to int to silence warning about comparing enums of different types

Review commit: https://reviewboard.mozilla.org/r/192340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192340/

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8921334 [details]
Bug 1411142 Cast enums to int to silence warning about comparing enums of different types

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192340/diff/1-2/

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Second: 

>  /builds/worker/workspace/build/src/dom/plugins/ipc/hangui/MiniShmBase.h: In instantiation of 'nsresult mozilla::plugins::MiniShmBase::GetWritePtr(T*&) [with T = mozilla::plugins::PluginHangUICommand]':
>  /builds/worker/workspace/build/src/dom/plugins/ipc/PluginHangUIParent.cpp:334:41:   required from here
>  /builds/worker/workspace/build/src/dom/plugins/ipc/hangui/MiniShmBase.h:133:23: error: comparison between 'enum mozilla::plugins::PluginHangUICommand::<anonymous>' and 'enum mozilla::plugins::MiniShmBase::ReservedCodes' [-Werror=enum-compare]
>           T::identifier <= RESERVED_CODE_LAST) {
>           ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8921334 [details]
Bug 1411142 Cast enums to int to silence warning about comparing enums of different types

https://reviewboard.mozilla.org/r/192340/#review197826

The template magic here is a little weird — in general that comparison is going to be between two different enums (with different ranges), so the int cast looks like the right way to deal with that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92b3336f6941
Cast enums to int to silence warning about comparing enums of different types r=jld

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/92b3336f6941