1411161 - Adds an initial react/redux template for loading an Events View in the inspector sidebar

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1411161 - Adds an initial react/redux template for loading an Events View in the inspector sidebar.

Review commit: https://reviewboard.mozilla.org/r/192388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192388/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8921353 [details]
Bug 1411161 - Adds an initial react/redux template for loading an Events View in the inspector sidebar.

https://reviewboard.mozilla.org/r/192388/#review197564

::: devtools/client/inspector/events/components/App.js:10
(Diff revision 1)
> +"use strict";
> +
> +const { addons, createClass, DOM: dom } = require("devtools/client/shared/vendor/react");
> +const { connect } = require("devtools/client/shared/vendor/react-redux");
> +
> +const App = createClass({

Can you check with Mike what his status on converting our components to classes is?
If he's really close, then it might be better to avoid using createClass here, and use an actual ES6 class instead.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

My intent is use the convertor after this lands since there will probably be better timing save from manually editing it and will be consistent across all React components.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/044aef4aae23
Adds an initial react/redux template for loading an Events View in the inspector sidebar. r=pbro

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out because it depends on bug 1411160 which got backed out for bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4bb530b68a55b48cfef3ce752dfb7c3d35c639

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db16a02d6d1
Adds an initial react/redux template for loading an Events View in the inspector sidebar. r=pbro

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1411161 and bug 1411160 for build bustage (duplicate files):

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4cadda2d0129e0cfff9f4e7da16595408a2bde
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db16a02d6d10ca6c9b3135f8d4f6f0bca0a8fce

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2db16a02d6d10ca6c9b3135f8d4f6f0bca0a8fce&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=139985262&repo=mozilla-inbound

[task 2017-10-26T20:31:17.345Z] 20:31:17     INFO -  WARNING: Found 20 duplicated files taking 36593 bytes (uncompressed)
[task 2017-10-26T20:31:17.346Z] 20:31:17     INFO -  ERROR: The following duplicated files are not allowed:
[task 2017-10-26T20:31:17.346Z] 20:31:17     INFO -  browser/chrome/devtools/modules/devtools/client/inspector/changes/types.js
[task 2017-10-26T20:31:17.346Z] 20:31:17     INFO -  browser/chrome/devtools/modules/devtools/client/inspector/events/types.js
[task 2017-10-26T20:31:17.346Z] 20:31:17     INFO -  /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:36: recipe for target 'stage-package' failed
[task 2017-10-26T20:31:17.346Z] 20:31:17     INFO -  gmake[7]: *** [stage-package] Error 1

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f13da6cbdf05
Backed out changeset 2db16a02d6d1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71de79227681
Adds an initial react/redux template for loading an Events View in the inspector sidebar. r=pbro

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/71de79227681