Closed Bug 1411196 Opened 2 years ago Closed 2 years ago

Updated |mach bootstrap| support 'mobile/android' builds on Gentoo to pick up a more recent JDK.

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1398935 +++

The jdk-8u144 is no more so for bootstrapping to work we need to pick up the current version instead. Since the URL changes every time Oracle updates the SDK the Gentoo-specific code needs to be updated to reflect it.
Comment on attachment 8921386 [details]
Bug 1411196 - Make mach bootstrap use the latest version of Oracle's JDK when building fennec;

https://reviewboard.mozilla.org/r/192418/#review197630
Attachment #8921386 - Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/106f4a9da29f
Make mach bootstrap use the latest version of Oracle's JDK when building fennec; r=froydnj
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #4)
> Backed out for flake8 linting failure at
> python/mozboot/mozboot/gentoo.py:55: line too long:
> 
> https://hg.mozilla.org/integration/autoland/rev/
> 785beebca649e2414245c409bcbce5df61bf8e89

Sigh, so lame.

Gabriele, if you could modify the commit message to also mention Gentoo-ness ("Make mach bootstrap on Gentoo..."?), that might be a good thing too.
Sure, (In reply to Nathan Froyd [:froydnj] from comment #5)
> Sigh, so lame.

:O I wasn't aware we had linting rules for Python too...

> Gabriele, if you could modify the commit message to also mention Gentoo-ness
> ("Make mach bootstrap on Gentoo..."?), that might be a good thing too.

Will do, I thought I did but it seems that I forgot.
Flags: needinfo?(gsvelto)
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb0bb12c7b0
Make |mach bootstrap| on Gentoo use the latest version of Oracle's JDK for Fennec builds; r=froydnj
https://hg.mozilla.org/mozilla-central/rev/2fb0bb12c7b0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.