1411196 - Updated |mach bootstrap| support 'mobile/android' builds on Gentoo to pick up a more recent JDK.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1398935 +++

The jdk-8u144 is no more so for bootstrapping to work we need to pick up the current version instead. Since the URL changes every time Oracle updates the SDK the Gentoo-specific code needs to be updated to reflect it.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1411196 - Make mach bootstrap use the latest version of Oracle's JDK when building fennec;

Review commit: https://reviewboard.mozilla.org/r/192418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192418/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8921386 [details]
Bug 1411196 - Make mach bootstrap use the latest version of Oracle's JDK when building fennec;

https://reviewboard.mozilla.org/r/192418/#review197630

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106f4a9da29f
Make mach bootstrap use the latest version of Oracle's JDK when building fennec; r=froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for flake8 linting failure at python/mozboot/mozboot/gentoo.py:55: line too long:

https://hg.mozilla.org/integration/autoland/rev/785beebca649e2414245c409bcbce5df61bf8e89

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=106f4a9da29f0a189808f885197d4afc0274d0c2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=139178578&repo=autoland
> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozboot/mozboot/gentoo.py:55:100 | line too long (128 > 99 characters) (E501)

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #4)
> Backed out for flake8 linting failure at
> python/mozboot/mozboot/gentoo.py:55: line too long:
> 
> https://hg.mozilla.org/integration/autoland/rev/
> 785beebca649e2414245c409bcbce5df61bf8e89

Sigh, so lame.

Gabriele, if you could modify the commit message to also mention Gentoo-ness ("Make mach bootstrap on Gentoo..."?), that might be a good thing too.

Comment 6

[Gabriele Svelto [:gsvelto]]

Sure, (In reply to Nathan Froyd [:froydnj] from comment #5)
> Sigh, so lame.

:O I wasn't aware we had linting rules for Python too...

> Gabriele, if you could modify the commit message to also mention Gentoo-ness
> ("Make mach bootstrap on Gentoo..."?), that might be a good thing too.

Will do, I thought I did but it seems that I forgot.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb0bb12c7b0
Make |mach bootstrap| on Gentoo use the latest version of Oracle's JDK for Fennec builds; r=froydnj

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2fb0bb12c7b0