1411197 - in_app quit/restart without a callable callback accidentally performs a shutdown

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While inspecting the quit/restart code lately I noticed that in case a callback is specified but not callable, we do not raise an exception, but silently restart the application via the else case:

https://dxr.mozilla.org/mozilla-central/rev/ce1a86d3b4db161c95d1147676bbed839d7a4732/testing/marionette/client/marionette_driver/marionette.py#1091-1095

The else case should really only be executed if callback is None.

When fixing this wrong behavior it would be good to get the tests in test_quit_restart.py updated, or new tests added for missing scenarios.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, maybe this is related to the issue I'm currently facing with the callback and no shutdown tests over on bug 1389103. I will take it.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1411197 - Quit/Restart without a callable callback shouldn't perform a shutdown.

Review commit: https://reviewboard.mozilla.org/r/193958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193958/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8922807 [details]
Bug 1411197 - Quit/Restart without a callable callback shouldn't perform a shutdown.

https://reviewboard.mozilla.org/r/193958/#review199166

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49053213ce32
Quit/Restart without a callable callback shouldn't perform a shutdown. r=maja_zf

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/49053213ce32