1411201 - Don't disable inlining on debug builds

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1411201 - Don't disable inlining in mozjemalloc on debug builds.

The way inlining is disabled in mozjemalloc is via a #define of "inline"
to nothing, which is a dubious way to do that. This makes the compiler
trigger warnings we -Werror on for some static functions. While there
are such functions in mozjemalloc.cpp that could be fixed by wrapping
them in the right #ifdefs, there are also others coming from headers,
and it's not something that can be fixed in a satisfactory way.

The right way to disable inlining is to pass the right compiler flags
for that. But inlining is the least of the problems to debug optimized
C++ code, so it feels like if debugging requires some optimization
tweaking, it should be done manually with compile flags when needed,
instead of fiddling with #defines to remove keywords.

Review commit: https://reviewboard.mozilla.org/r/192434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192434/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8921395 [details]
Bug 1411201 - Don't disable inlining in mozjemalloc on debug builds.

https://reviewboard.mozilla.org/r/192434/#review197786

Sounds good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43695cf06e96
Don't disable inlining in mozjemalloc on debug builds. r=njn

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/43695cf06e96