Closed Bug 1411290 Opened 3 years ago Closed 3 years ago

Text to block/allow pop-ups in identity manager is heavily truncated in localized builds

Categories

(Firefox :: Site Identity, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- unaffected
firefox58 --- verified

People

(Reporter: flod, Assigned: prathiksha)

References

Details

Attachments

(2 files)

Italian is not much longer than English (Blocca vs Block, Permetti vs Allow), and yet the controls are unusable, since the label is truncated and not readable.
Summary: Block/Allow button for pop-ups are impossible to read in localized builds (text is truncated) → Text to block/allow pop-ups in identity manager is heavily truncated in localized builds
Sorry for the noise, clone the wrong bug (I meant to clone and block bug 1331931).
Blocks: 1331931
No longer blocks: 1379560
Component: Permission Manager → Site Identity and Permission Panels
Product: Core → Firefox
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Attachment #8921576 - Flags: feedback?(jhofmann)
Attachment #8921576 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8921576 [details]
Bug 1411290 - Make menulist label text visible for popup permission in identity manager in localized builds.

Sorry, not really entitled to give feedback on this kind of code changes ;-)
Attachment #8921576 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8921576 [details]
Bug 1411290 - Make menulist label text visible for popup permission in identity manager in localized builds.

https://reviewboard.mozilla.org/r/192594/#review197980

I'm a bit hesitant about this, but I'd say it's generally ok with me. I'm a bit annoyed that the menulist changes size when selecting a different item, but I don't think we have to spend too much time or thought on this. :)

::: browser/themes/shared/notification-icons.inc.css
(Diff revision 1)
>    list-style-image: url("chrome://browser/skin/notification-icons/popup-subitem.svg");
>    margin-inline-start: 30px;
>  }
>  
> -.identity-popup-popup-menulist {
> -  width: 72px;

Maybe we should consider changing this to min-width? That would at least prevent jumping on some locales, e.g. English, and prevent the menulist from getting tiny when the word for allow/block is only a few letters.
(In reply to Johann Hofmann [:johannh] from comment #4)
> > -.identity-popup-popup-menulist {
> > -  width: 72px;
> 
> Maybe we should consider changing this to min-width? That would at least
> prevent jumping on some locales, e.g. English, and prevent the menulist from
> getting tiny when the word for allow/block is only a few letters.

If we want to keep a min-width here, we should use em rather than px for that.
Comment on attachment 8921576 [details]
Bug 1411290 - Make menulist label text visible for popup permission in identity manager in localized builds.

https://reviewboard.mozilla.org/r/192594/#review198756

Seems reasonable, though I'd say we should give it a little (1em?) more min-width.

Thank you!
Attachment #8921576 - Flags: review?(jhofmann) → review+
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d60b8971ecd9
Make menulist label text visible for popup permission in identity manager in localized builds. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d60b8971ecd9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Reproduced this issue on Nightly 58.oa1 (2017-10-24).

Verified fixed using the latest Nightly 59.0a1 (2017-11-13)and FF Beta 58.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.