1411301 - Right clicking on top sites (e.g. facebook) on about:newtab shows 'search for f facebook'

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Erik Hellberg]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171019140425

Steps to reproduce:

When viewing the frequently visited page, a right click reveals the contextmenu.One of the items is "Search google for [insert the page name]". It however doubles the first letter of each frequently visited site.

"Search google for f facebook", "search google for s sweclockers", "search google for f flashback" etc.


Actual results:

Nothing happens, beyond google opening and searching for the site name although with a double first letter.

Comment 1

[Kohei Yoshino [:kohei]]

Please troubleshoot with Safe Mode: https://support.mozilla.org/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 2

[Erik Hellberg]

(In reply to Kohei Yoshino [:kohei] from comment #1)
> Please troubleshoot with Safe Mode:
> https://support.mozilla.org/kb/troubleshoot-firefox-issues-using-safe-mode

This does appear to "fix" it, but i am uncertain if safe mode does anything else but start firefox without addons. The only addon i am using is "Ublock Origin". I doubt it'd interfere with context menues. When i exit safe mode, the issue persists.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I can confirm this bug. I'm unable to use mozregression to test this bug since this page is hosted.

Comment 4

[Ed Lee :Mardak]

The initial letter is from the placeholder text that is visible when there's no screenshot or icon. Not sure what you mean by it's hosted though -- the page is packaged as part of mozilla-central if you're referring to remotely hosted.

The placeholder letter has been there probably from the beginning of the system-addon code, so not really a regression.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Okay, yes I tested with mozregression and saw the issue from the earliest introduction of activity stream and thought maybe it was hosted in some fashion.

Comment 6

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3811 to be uplifted via bug 1415812.

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible using the latest Nightly 59.0a1 (Build ID 20171119220126) on Windows 10 x64, Mac 10.12.6 and Arch Linux x64.