1411374 - Error from redefinition of PATH_MAX in js/src/shell/OSObject.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Ritter [:tjr] (OOTO until April)]

Similar to Bug #1409579, we shouldn't redefine PATH_MAX if we already have.

>  /builds/worker/workspace/build/src/js/src/shell/OSObject.cpp:40:0: error: "PATH_MAX" redefined [-Werror]
>   # define PATH_MAX (MAX_PATH > _MAX_DIR ? MAX_PATH : _MAX_DIR)
>  In file included from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:168:0,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/syslimits.h:7,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:34,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/stdlib.h:10,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/cstdlib:75,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/stdlib.h:36,
>                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:49,
>                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/AlreadyAddRefed.h:12,
>                   from /builds/worker/workspace/build/src/js/src/jsapi.h:12,
>                   from /builds/worker/workspace/build/src/js/src/shell/OSObject.h:12,
>                   from /builds/worker/workspace/build/src/js/src/shell/OSObject.cpp:9,
>                   from /builds/worker/workspace/build/src/obj-firefox/js/src/shell/Unified_cpp_js_src_shell0.cpp:2:
>  /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/limits.h:20:0: note: this is the location of the previous definition
>   #define PATH_MAX 260

Comment 1

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: Bug 1411374 Do not redefine PATH_MAX if it is already defined

Review commit: https://reviewboard.mozilla.org/r/192610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192610/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8921587 [details]
Bug 1411374 Do not redefine PATH_MAX if it is already defined

https://reviewboard.mozilla.org/r/192610/#review197810

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46942fe1678
Do not redefine PATH_MAX if it is already defined r=njn

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c46942fe1678