Closed Bug 1411374 Opened 5 years ago Closed 5 years ago

Error from redefinition of PATH_MAX in js/src/shell/OSObject.cpp

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1411374 Do not redefine PATH_MAX if it is already defined
59 bytes, text/x-review-board-request
n.nethercote
: review+
Details 
Similar to Bug #1409579, we shouldn't redefine PATH_MAX if we already have.

>  /builds/worker/workspace/build/src/js/src/shell/OSObject.cpp:40:0: error: "PATH_MAX" redefined [-Werror]
>   # define PATH_MAX (MAX_PATH > _MAX_DIR ? MAX_PATH : _MAX_DIR)
>  In file included from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:168:0,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/syslimits.h:7,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:34,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/stdlib.h:10,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/cstdlib:75,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/stdlib.h:36,
>                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:49,
>                   from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/AlreadyAddRefed.h:12,
>                   from /builds/worker/workspace/build/src/js/src/jsapi.h:12,
>                   from /builds/worker/workspace/build/src/js/src/shell/OSObject.h:12,
>                   from /builds/worker/workspace/build/src/js/src/shell/OSObject.cpp:9,
>                   from /builds/worker/workspace/build/src/obj-firefox/js/src/shell/Unified_cpp_js_src_shell0.cpp:2:
>  /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/limits.h:20:0: note: this is the location of the previous definition
>   #define PATH_MAX 260
Comment on attachment 8921587 [details]
Bug 1411374 Do not redefine PATH_MAX if it is already defined

https://reviewboard.mozilla.org/r/192610/#review197810
Attachment #8921587 - Flags: review?(n.nethercote) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c46942fe1678
Do not redefine PATH_MAX if it is already defined r=njn
Keywords: checkin-needed
Component: DOM → JavaScript Engine
https://hg.mozilla.org/mozilla-central/rev/c46942fe1678
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.