Closed Bug 1411459 Opened 7 years ago Closed 7 years ago

Correct and update the "screen resolution is too low" reftest error messages

Categories

(Testing :: Reftest, enhancement)

x86
macOS
enhancement
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

Spinning this off from bug 1263092.

When the screen resolution is "too low", the reftest harness prints out the following error messages:

REFTEST ERROR | USE_WIDGET_LAYERS disabled because the screen resolution is too
low. This falls back to an alternate rendering path (that may not be
representative) and is not implemented with e10s enabled.
REFTEST ERROR | Consider increasing your screen resolution, or adding
'--disable-e10s' to your './mach reftest' command

The --disable-e10s flag no longer works around this issue, and there are other workarounds that could me mentioned, with caveats. We should update these messages.
The upcoming patch changes the error message to the following when e10s is enabled:

REFTEST ERROR | Screen resolution is too low - USE_WIDGET_LAYERS was disabled. Since e10s is enabled, there is no fallback rendering path!
REFTEST ERROR | If you cannot increase your screen resolution you can try reducing gecko's pixel scaling by adding something like '--setpref layout.css.devPixelsPerPx=1.0' to your './mach reftest' command (possibly as an alias in ~/.mozbuild/machrc). Note that this is inconsistent with CI testing, and may interfere with HighDPI/reftest-zoom tests.

and the following when e10s is disabled:

REFTEST ERROR | Screen resolution is too low - USE_WIDGET_LAYERS was disabled. The fallback rendering path is not reliably consistent with on-screen rendering.
REFTEST ERROR | If you cannot increase your screen resolution you can try reducing gecko's pixel scaling by adding something like '--setpref layout.css.devPixelsPerPx=1.0' to your './mach reftest' command (possibly as an alias in ~/.mozbuild/machrc). Note that this is inconsistent with CI testing, and may interfere with HighDPI/reftest-zoom tests.
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #8921689 - Flags: review?(matt.woodrow)
Attachment #8921689 - Flags: review?(matt.woodrow) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e079bdfa614
Correct and update the "screen resolution is too low" reftest error messages. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/6e079bdfa614
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: