Closed Bug 1411525 Opened 5 years ago Closed 5 years ago

Use BufferReader in flac/ogg parser

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → ayang
Blocks: 1392177
No longer depends on: 1392177
Comment on attachment 8921814 [details]
Bug 1411525 - use BufferReader in flac/ogg parser.

https://reviewboard.mozilla.org/r/192842/#review198350

::: media/libstagefright/binding/include/mp4_demuxer/BufferReader.h:14
(Diff revision 1)
>  #include "nscore.h"
>  #include "nsTArray.h"
>  #include "MediaData.h"
>  #include "mozilla/Result.h"
>  
> +using namespace mozilla;

I think it'd be better to add a mozilla:: prefix to whatever needed it here, it's generally a bad idea to have "using namespace" in a header since it can surprise anyone including it.
Attachment #8921814 - Flags: review?(kinetik) → review+
Comment on attachment 8921814 [details]
Bug 1411525 - use BufferReader in flac/ogg parser.

https://reviewboard.mozilla.org/r/192842/#review198384

::: media/libstagefright/binding/include/mp4_demuxer/BufferReader.h:14
(Diff revision 1)
>  #include "nscore.h"
>  #include "nsTArray.h"
>  #include "MediaData.h"
>  #include "mozilla/Result.h"
>  
> +using namespace mozilla;

Fixed, thanks for comment.
Blocks: 1411815
No longer blocks: 1411815
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb2cbfa4a06a
use BufferReader in flac/ogg parser. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/eb2cbfa4a06a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.