1411534 - "[XXX] Build of YYY" emails are duplicated on release-mgmt and release-signoff

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Julien Cristau [:jcristau]]

I think there should be a single mail to both recipients (or just to release-signoff), rather than two separate emails.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Might be trickier a bit to send the email to both recipients. We're using puppet[1] to specify the addresses and this[2] function  to actually send the email. As you can see, there's for loop iterating there. We could change that and amend it but that implies we need to revisit the other occurrences and usage of that function within the code. The simple fix here is to send the email to release-signoff only, if RelMan approves this. 

@jcristau: what do you think? Green flag to trim release-mgtm from it?


[1]: https://dxr.mozilla.org/build-central/source/puppet/manifests/moco-config.pp#292
[2]: https://dxr.mozilla.org/build-central/source/tools/lib/python/util/sendmail.py

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Yes this is fine

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1411534 - stop sending emails to release management and keep release-signoff only.

Review commit: https://reviewboard.mozilla.org/r/192874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192874/

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8921839 [details]
Bug 1411534 - stop sending emails to release management and keep release-signoff only.

https://reviewboard.mozilla.org/r/192874/#review198102

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8921839 [details]
Bug 1411534 - stop sending emails to release management and keep release-signoff only.

https://hg.mozilla.org/build/puppet/rev/3f6e78764d7f
https://hg.mozilla.org/build/puppet/rev/9c3635d0139a5ff738d4031c7204ef103350a6b2

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

I'll bring up to our weekly meeting the actual long-term fix for this problem and follow-up in a separate bug if we go for it.