1411548 - Fix puppet lint warnings from travis job

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dragos Crisan [:dragrom]]

On build https://travis-ci.org/mozilla/build-puppet/builds/292219132, I found the following warnings:

puppet-lint --no-140chars-check --no-case_without_default-check --no-only_variable_string-check --no-unquoted_file_mode-check --no-nested_classes_or_defines --no-quoted_booleans --no-puppet_url_without_modules --no-selector_inside_resource --no-file_mode-check --no-variable_scope-check --no-arrow_on_right_operand_line --no-double_quoted_strings-check --no-autoloader_layout-check --log-format '%{path} - %{KIND}: %{message} on line %{line} - %{check}' `find manifests modules -name '*.pp' -not -path 'modules/acl/*' -not -path 'modules/assert/*' -not -path 'modules/concat/*' -not -path 'modules/firewall/*' -not -path 'modules/java_ks/*' -not -path 'modules/powershell/*' -not -path 'modules/registry/*' -not -path 'modules/stdlib/*' -not -path 'modules/windows_firewall/*' -not -path 'modules/windows_path/*'`

modules/fw/manifests/pre.pp - WARNING: indentation of => is not properly aligned (expected in column 20, but found it in column 21) on line 32 - arrow_alignment

modules/fw/manifests/pre.pp - WARNING: indentation of => is not properly aligned (expected in column 20, but found it in column 21) on line 33 - arrow_alignment

modules/fw/manifests/pre.pp - WARNING: indentation of => is not properly aligned (expected in column 20, but found it in column 21) on line 34 - arrow_alignment

modules/fw/manifests/pre.pp - WARNING: indentation of => is not properly aligned (expected in column 20, but found it in column 21) on line 35 - arrow_alignment

Comment 1

[Dragos Crisan [:dragrom]]

Attachment: Bug_1411548_Fix_puppet_lint_warnings_from_travis_job.patch

Arranged =>. Looking to puppet style guide:

Arrow alignment:

Hash rockets (=>) in a resource’s attribute/value list may be aligned. The hash rockets should be placed one space ahead of the longest attribute name

Comment 2

[Dragos Crisan [:dragrom]]

Comment on attachment 8921848 [details] [diff] [review]
Bug_1411548_Fix_puppet_lint_warnings_from_travis_job.patch

https://hg.mozilla.org/build/puppet/rev/a1a8e99f033630d579fa423826cf902bc0aa18d3
https://hg.mozilla.org/build/puppet/rev/97da9d8e4ee160b3c2c1bd2516f5956f0155a055