141156 - incorrect address shown when asking for a password

Status: RESOLVED DUPLICATE of bug 212937

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Antonio Asensi Esteve]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.0rc1) Gecko/20020417
BuildID:    2002041711

* The context is:
You have an e-mail account like “[e-mail]“
Your pop server is “pop.domain.com”
In Mozilla your account name is “user”
AND the “user name”, that the server asks you, is “[e-mail]“ (yes, with the “@”)

* When you click “get mail” it says:
“Enter your password for [e-mail]@pop.domain.com”
It should say
“Enter your password for [e-mail]”

* Other contexts:
If your “user name” was “user;domain.com“ you would have 
“Enter your password for user;[e-mail]”

It should be very easy to fix.  

Reproducible: Always
Steps to Reproduce:
1. Put this configuration or similar, don't write a password there, it has to ask you.
2. Click "Get Mail"

Comment 1

[James Carr]

I have noticed this also.

Comment 2

[Mikael Parknert]

Reporter - is this still a problem? If not, please close the bug!

Comment 3

[Marat Khalili]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

It still works the way described in bug report because mozilla uses
"<pop-user-name>@<pop-host-name>" in the mentioned dialog while <pop-user-name>
is often a complete email address these days. Correct solution is "user
<pop-user-name> at host <pop-host-name>" although this would look slightly
confusing too (but, again, correct).

It all lives in localMsgs.properties:

## @name POP3_ENTER_PASSWORD_PROMPT
## @loc None
# LOCALIZATION NOTE(4016): Do not translate the word "%1$s@%2$s" below.
# Place the word "%1$s@%2$s" where email account name should appear (i.e.
[e-mail])
4017=Enter your password for %1$s@%2$s:

## @name POP3_PREVIOUSLY_ENTERED_PASSWORD_IS_INVALID_ETC
## @loc None
# LOCALIZATION NOTE(4016): Do not translate the word "%s" below. It will receive
the message returned by the server.
# Do not translate "%.100s@%.100s". It will receive the email account name.
4018=Please enter a new password for user %.100s@%.100s:

Comment 4

[Joe Infla]

duping this to a younger but more active bug (with patch)...

*** This bug has been marked as a duplicate of 212937 ***

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 141156 - Set MOZ_DEBUG globally as both a CONFIG and a #define.

Bug 1365460 introduced code paths behind MOZ_DEBUG #ifdefs, but
MOZ_DEBUG is never defined, while it is available in CONFIG in
moz.builds. This is kind of a confusing situation, but the fact that
we've been able to avoid those problems for so long would tend to
put the blame on mozjemalloc, and fixes should go there.

Except that bug 1261161 explains that the only existing alternative
(the DEBUG #define), as used in MFBT, is not working for spidermonkey,
so it actually makes sense to converge to MOZ_DEBUG rather than DEBUG.

So start defining MOZ_DEBUG globally, fixing the mozjemalloc issues of
not having the debug code enabled. Bug 1261161 can then take care of
changing the DEBUG #ifdefs.

Review commit: https://reviewboard.mozilla.org/r/192366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192366/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8921341 [details]
Bug 141156 - Set MOZ_DEBUG globally as both a CONFIG and a #define.

Wrong bug

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8921341 [details]
Bug 141156 - Set MOZ_DEBUG globally as both a CONFIG and a #define.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192366/diff/1-2/

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8921341 [details]
Bug 141156 - Set MOZ_DEBUG globally as both a CONFIG and a #define.

PEBKAC