1411584 - -Wclass-memaccess: clearing an object of non-trivial type 'struct mozilla::dom::GamepadPoseState';

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

/root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/GamepadPoseState.h: In member function 'void mozilla::dom::GamepadPoseState::Clear()':
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/GamepadPoseState.h:85:45: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct mozilla::dom::GamepadPoseState'; use assignment or value-initialization instead [-Werror=class-memaccess]
      memset(this, 0, sizeof(GamepadPoseState));

Comment 1

[Andi [:andi]]

This is a good catch, since we need to have this landed: 525063

Comment 2

[Andi [:andi]]

Attachment: Bug 1411584 - avoid using memset on a non-trivial type object.

Review commit: https://reviewboard.mozilla.org/r/193260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193260/

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8922232 [details]
Bug 1411584 - avoid using memset on a non-trivial type object.

https://reviewboard.mozilla.org/r/193260/#review198750

I believe the intention here was for this to be a POD type, but perhaps it is being promoted to non-trivial due to the constructor.

Perhaps we could do some static asserts in the future where we depend on something being a POD to catch these.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/907068074409
avoid using memset on a non-trivial type object. r=kip

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/907068074409