Closed Bug 1411585 Opened 2 years ago Closed 2 years ago

nsprpub/* has many missing files with no BUGZILLA_COMPONENT mapping in-tree

Categories

(NSPR :: NSPR, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
Tracking Status
firefox58 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

We now have a job run per/push which generates a map of source files -> bugzilla_component.  Ideally that job will go orange when we find files that do not have a clear owner- ownership is important in open source so when there are issues or questions with code any contributor can raise a bug and get it to the right people.

right now I believe all of the nsprpub files have no mapping:
$ ./mach file-info bugzilla-component nsprpub/**
UNKNOWN
  nsprpub/LICENSE
  nsprpub/TAG-INFO
  nsprpub/admin
  nsprpub/automation
  nsprpub/build
  nsprpub/config
  nsprpub/configure
  nsprpub/configure.in
  nsprpub/lib
  nsprpub/patches
  nsprpub/pkg
  nsprpub/pr
  nsprpub/tools
Core :: Build Config
  nsprpub/Makefile.in
:jcj, how can we get a list of what bugzilla_components nsprpub/** files should map to?  I suspect this needs a bit more granularity than top level directories, but any pointers to get started would be great.
Flags: needinfo?(jjones)
of course I could default everything to NSPR::NSPR :)
I think that's fine. I don't think further granularity is particularly useful. NSPR is not a well-maintained project.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8921886 - Flags: review?(ted)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> I think that's fine. I don't think further granularity is particularly
> useful. NSPR is not a well-maintained project.

Agreed. Let's just start here.
Flags: needinfo?(jjones)
Comment on attachment 8921886 [details] [diff] [review]
add moz.build file to nsprpub/ so we have BUGZILLA_COMPONENTS

Unfortunately this will break things because nsprpub gets vendored from the upstream repository, which is just going to remove this file.

We do have a set of moz.build files that we use to build NSPR independent of its own build system:
https://dxr.mozilla.org/mozilla-central/source/config/external/nspr/moz.build

...but unfortunately, from my reading of the code that implements `Files` and `mach file-info`, you can't use topsrcdir-relative paths in patterns for `Files`, so you can't put this info there.

I'd suggest just putting this in the top-level moz.build as a compromise. It's only two lines anyway.
Attachment #8921886 - Flags: review?(ted) → review-
thanks for the previous review, this will fit in the existing root directory moz.build file just fine.
Attachment #8921886 - Attachment is obsolete: true
Attachment #8921968 - Flags: review?(ted)
Attachment #8921968 - Flags: review?(ted) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bab553532011
nsprpub/* has many missing files with no BUGZILLA_COMPONENT mapping in-tree. r=ted
https://hg.mozilla.org/mozilla-central/rev/bab553532011
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.