Closed
Bug 1411586
Opened 7 years ago
Closed 7 years ago
mfbt is missing BUGZILLA_COMPONENTS defined in-tree
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
846 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We now have a job run per/push which generates a map of source files -> bugzilla_component. Ideally that job will go orange when we find files that do not have a clear owner- ownership is important in open source so when there are issues or questions with code any contributor can raise a bug and get it to the right people. $ ./mach file-info bugzilla-component mfbt/** UNKNOWN mfbt/Alignment.h mfbt/AllocPolicy.h mfbt/AlreadyAddRefed.h mfbt/Array.h mfbt/ArrayUtils.h mfbt/Assertions.cpp mfbt/Assertions.h mfbt/Atomics.h mfbt/Attributes.h mfbt/BinarySearch.h mfbt/BloomFilter.h ...
Assignee | ||
Comment 1•7 years ago
|
||
:froydnj, should I default all files to Core::MFBT, or is there a better breakdown?
Flags: needinfo?(nfroyd)
Comment 2•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #1) > :froydnj, should I default all files to Core::MFBT, or is there a better > breakdown? Core::MFBT is fine, thanks.
Flags: needinfo?(nfroyd)
Assignee | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8921883 [details] [diff] [review] set BUGZILLA_COMPOENT for mfbt/** == Core::MFBT Review of attachment 8921883 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8921883 -
Flags: review?(nfroyd) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf297389fd46 mfbt is missing BUGZILLA_COMPONENTS defined in-tree. r=froydnj
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf297389fd46
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•