Shapes highlighter: resize on one dimension in transform mode.

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
25 days ago
5 days ago

People

(Reporter: mparkms, Assigned: mparkms)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [designer-tools])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

25 days ago
In the CSS shapes highlighter, you should be able to resize shapes just horizontally or vertically using markers placed on each edge of the bounding box in transform mode. This would be applicable to polygons, ellipses, and insets, but for insets, it would be identical to the behaviour of the highlighter in non-transform mode.
Whiteboard: [designer-tools]
Comment hidden (mozreview-request)

Comment 2

13 days ago
mozreview-review
Comment on attachment 8925103 [details]
Bug 1411645 - Shapes highlighter: resize on one axis in transform mode for polygon and ellipse.

https://reviewboard.mozilla.org/r/196342/#review202186

::: devtools/client/inspector/test/browser_inspector_highlighter-cssshape_06.js:134
(Diff revision 1)
>      isnot(seBB.width, swBB.width, `${shape} width reduced after se scale`);
>      isnot(seBB.height, swBB.height, `${shape} height reduced after se scale`);
>    }
>  }
>  
> +function* testOneDimScale(testActor, helper) {

I think you should move this to a different test. This one is getting quite long and might cause timeout when our CI gets slow.
Attachment #8925103 - Flags: review?(pbrosset) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

6 days ago
Keywords: checkin-needed

Comment 4

6 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6981bc3a8091
Shapes highlighter: resize on one axis in transform mode for polygon and ellipse. r=pbro
Keywords: checkin-needed
Backed out (Bug 1411645) for eslint failures /gecko/devtools/server/actors/highlighters/shapes.js:1904

Backout: https://hg.mozilla.org/integration/autoland/rev/cfbdb1dc35cd8071cb97bcdf0deeaabaa1e33bea 

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6981bc3a8091b9b43bcf124e1c7eee27adc35911

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=144387069&repo=autoland&lineNumber=242 

[task 2017-11-13T20:24:40.867Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
242
[task 2017-11-13T20:32:06.713Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/highlighters/shapes.js:1904:1 | Line 1904 exceeds the maximum line length of 90. (max-len)
243
[taskcluster 2017-11-13 20:32:07.455Z] === Task Finished ===
Flags: needinfo?(mpark)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 days ago
Flags: needinfo?(mpark)
Keywords: checkin-needed

Comment 7

5 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6e02657a32a8
Shapes highlighter: resize on one axis in transform mode for polygon and ellipse. r=pbro
Keywords: checkin-needed

Comment 8

5 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6e02657a32a8
Status: NEW → RESOLVED
Last Resolved: 5 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.