Closed Bug 1411648 Opened 5 years ago Closed 5 years ago
Dark border appears below the Tabbar
Nightly 58.0a1 (2017-10-25) (64-Bit) macOS 10.12.6 Steps to reproduce: 1.) Open a new window Actual: Dark border appears below the Tabbar. Expected: No dark line should appear below the Tabbar. This is a regression. A screenshot is attached. A bisect will follow.
Regression Range: Good: 2017-10-24-22-03-25 Bad: 2017-10-25-10-04-49
Dão: May be https://hg.mozilla.org/mozilla-central/rev/f5121cba7d7b ?
(In reply to Mehmet from comment #2) > Dão: May be https://hg.mozilla.org/mozilla-central/rev/f5121cba7d7b ? Yep, probably.
Maybe I shouldn't have removed var(--tab-toolbar-navbar-overlap) here: https://hg.mozilla.org/mozilla-central/rev/f5121cba7d7b#l4.11 The titlebar styling is pretty confusing on Mac...
Note that in the screenshot tests this is not happening for lwthemes, for whatever reason: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=a124f4901430f6db74cfc7fe3b07957a1c691b40&newProject=mozilla-central&newRev=252a8528c5ab4affc2742e7ccfe4ef4aa5ee42f8
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8922289 [details] Bug 1411648 - Remove leftover z-index and bogus border from the nav bar. https://reviewboard.mozilla.org/r/193346/#review198576
Attachment #8922289 - Flags: review?(nhnt11) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/60904a2148ce Remove leftover z-index and bogus border from the nav bar. r=nhnt11
I verified this issue using latest Nightly 58.0a1 and latest Firefox Beta 57.0b14 with Build ID 20171102181127 on Mac OS X 10.12 I will mark this as verified fixed.
You need to log in before you can comment on or make changes to this bug.