1411661 - Our copy of Speedometer is missing statistics.js from a higher directory

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

Running tests locally I see a bunch of:
127.0.0.1 - - [25/Oct/2017 12:44:01] code 404, message File not found
127.0.0.1 - - [25/Oct/2017 12:44:01] "GET /resources/statistics.js HTTP/1.1" 404

I started my server in the "speedometer" directory, but index.html does:
<script src="../resources/statistics.js" defer></script>

It means we miss out on the "+/- N" indicator at the end. Also the lack of this code might affect the work the test is doing and make an unrepresentative test (it's unlikely -- my local numbers seem pretty steady -- but who knows).

Comment 1

[(Away)]

Attachment: hg mv

This creates a third_party/webkit/ under which we mirror their tree structure. Specifically, Speedometer lives under PerformanceTests/Speedometer.

`hg mv` patch only, the other changes will be in another patch for clarity.

Comment 2

[(Away)]

Attachment: Add resources.js and update PGO paths

jmaher -- apparently this stuff has changed such that Talos consumes the output nowadays. This change won't break any Talos expectations, right?

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8921979 [details] [diff] [review]
hg mv

r=me, I guess, but why is this necessary?

Comment 4

[(Away)]

(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8921979 [details] [diff] [review]
> hg mv
> 
> r=me, I guess, but why is this necessary?

The minimal fix would be to add third_party/resources/statistics.js, but I didn't want to add this naked "resources" directory without any indication of where it came from.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8921980 [details] [diff] [review]
Add resources.js and update PGO paths

Review of attachment 8921980 [details] [diff] [review]:
-----------------------------------------------------------------

we copy the speedometer files to testing/talos/talos/tests/:
http://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/test_archive.py#375

can you run this on try with talos? |./mach try fuzzy -q '!pgo linux speedometer'|

Comment 6

[(Away)]

Attachment: Fix up Talos files

Thanks for the pointer, I had missed a couple of Talos files.

Try looks reasonable:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70ed17157547ac1b3ffc6939e66371ab714645c7&group_state=expanded&selectedJob=139595783

13:45:22     INFO -  PID 13187 | |0;VanillaJS-TodoMVC/Adding100Items/Sync;96.29499999999999;101.31999999999971;95.78499999999985;98.05500000000029;99.875;96.04000000000002;98.55000000000109;100.70000000000073;99.50499999999738;98.49000000000524;98.02000000000001;107.22999999999956;99.06999999999971;98.6050000000032;98.65499999999884;100.125;98.79500000000007;103.38000000000102;101.70499999999447;98.93499999999767;97.965;102.24499999999898;99.20500000000175;99.34500000000116;99.56999999999971

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8922088 [details] [diff] [review]
Fix up Talos files

Review of attachment 8922088 [details] [diff] [review]:
-----------------------------------------------------------------

thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f24e165618
Push Speedometer files down a level so they can refer to "../resources". r=froydnj,jmaher

Comment 9

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/e3f24e165618