14117 - [patch] build bustage in nsRelatedLinksHandler.cpp

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[tor]

In xpfe/components/related/src/nsRelatedLinksHandler.cpp there is a line
which attempts to take the address of a temporary class instance.  Some
compilers (such as SUNWspro 5.0) refuse to deal with it.  Happily the fix
is trivial:

Index: nsRelatedLinksHandler.cpp
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/related/src/nsRelatedLinksHandler.cpp,v
retrieving revision 1.18
diff -u -r1.18 nsRelatedLinksHandler.cpp
--- nsRelatedLinksHandler.cpp   1999/09/17 02:26:25     1.18
+++ nsRelatedLinksHandler.cpp   1999/09/17 04:01:02
@@ -196,7 +196,8 @@
                                (nsISupports**)&charsetConv);
                if (NS_SUCCEEDED(rv) && (charsetConv))
                {
-                       rv = charsetConv->GetUnicodeDecoder(&nsString("UTF-8"),
+                       nsString utf8("UTF-8");
+                       rv = charsetConv->GetUnicodeDecoder(&utf8,
                                getter_AddRefs(mUnicodeDecoder));
                        NS_RELEASE(charsetConv);
                }

Comment 1

[Robert John Churchill]

Fix checked in.  Thanks!

Comment 2

[Eli Goldberg]

Since browser QA does not have the ability to verify code-level fixes, this is
being rubber-stamped as verified.

Comment 3

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/97750fddc7b3
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/14117: Add Synced Tabs as a page in the tabs tray