1411711 - Remove MOZ_D3DCOMPILER_XP_CAB, move MOZ_D3DCOMPILER_VISTA_DLL_PATH to moz.build

Status: NEW

(Core :: Graphics, enhancement, P5)

Description

[(not currently active) Ted Mielczarek]

gfx/angle/Makefile.in has a libs rule to copy some files out of the Windows SDK:
https://hg.mozilla.org/mozilla-central/file/e56ae7213756d93da1c1c72805c8f8b8ddb9dcdd/gfx/angle/Makefile.in#l7

Given that we no longer support Vista or XP, I would guess that we probably don't need those rules anymore.

Comment 1

[(not currently active) Ted Mielczarek]

Bas: do we still need to ship these files for Windows builds?

It doesn't look like MOZ_D3DCOMPILER_XP_CAB is actually set for any of our builds:
https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=MOZ_D3DCOMPILER_XP_CAB

We copy d3dcompiler_47.dll out of the Windows SDK:
https://dxr.mozilla.org/mozilla-central/rev/a124f4901430f6db74cfc7fe3b07957a1c691b40/old-configure.in#2924

Is that still needed now that we've dropped Vista support?

Comment 2

[Masatoshi Kimura [:emk]]

MOZ_D3DCOMPILER_VISTA_DLL_PATH is used for Vista *or later*. Perhaps we should rename the misleading name.

Removing MOZ_D3DCOMPILER_VISTA_DLL_PATH is fine.

Comment 3

[Masatoshi Kimura [:emk]]

> Removing MOZ_D3DCOMPILER_VISTA_DLL_PATH is fine.

Correction: Removing MOZ_D3DCOMPILER_XP_CAB is fine.

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> MOZ_D3DCOMPILER_VISTA_DLL_PATH is used for Vista *or later*. Perhaps we
> should rename the misleading name.

Thanks! Resummarizing.

Comment 5

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals