1411727 - Update Debugger Frontend (10-25)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c05a2ed4db3e8d9ff4259ab454324ccf8bdf213b

Comment 2

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 3

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 4

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 5

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 6

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 7

[Jason Laster [:jlast]]

Attachment: patch-10-25-3.patch

Comment 8

[Jason Laster [:jlast]]

seeing an issue w/ the wasm test...

Comment 10

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bff2a3c2fac5ae0836ee13466037b1f1ac3d5ef

Comment 11

[Jason Laster [:jlast]]

Attachment: patch-10-25-4.patch

Comment 12

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca1a0d3fd6e8c3add9729986bf25f7af1a970e64

Comment 13

[Jason Laster [:jlast]]

Attachment: patch-10-25-6.patch

Comment 14

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef0bcd7302ed488c75d9bfd7a91224b00bbd12e6

Comment 15

[Jason Laster [:jlast]]

Attachment: patch-10-25-6.patch

Comment 16

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43f7b13d12cbedf6789942cc604f9e2e88385c82

Comment 17

[Jason Laster [:jlast]]

Attachment: patch-10-25-7.patch

Comment 18

[Julian Descottes [:jdescottes]]

With the new patch, the disabled icons for stepping are almost impossible to differentiate from the enabled ones.

Comment 19

[Julian Descottes [:jdescottes]]

Attachment: disable_step_icons.png

Comment 20

[Julian Descottes [:jdescottes]]

Comment on attachment 8922939 [details] [diff] [review]
patch-10-25-7.patch

Review of attachment 8922939 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, just one issue with the disabled icons (see previous comment + screenshot). 
Up to you if you want to fix it here or not.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: d9f18b2cd0792de70289d4dcde5ed3e38be87cf1

We discussed this on slack, but for the record: a good evolution for this would be to add the actual link to the debugger commit on GitHub. Even better would be to have a link to the compare view between this commit and the previous release commit.

Finally this information could also be added to the commit message (this way people who don't know about this file could still get the information easily.

Comment 21

[Jason Laster [:jlast]]

Lets push this patch and we'll fix the disable state in GH and patch on monday.

Thanks for the updates on the readme, i made an issue for it here: https://github.com/jasonLaster/ship2gecko/issues/2

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/129dfaaf265a
Update Debugger frontend (10-25). r=jdescottes

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/129dfaaf265a