Closed Bug 1411727 Opened 5 years ago Closed 5 years ago

Update Debugger Frontend (10-25)

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(2 files, 9 obsolete files)

No description provided.
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922106 - Flags: review?(jdescottes)
Attachment #8922106 - Attachment is obsolete: true
Attachment #8922106 - Flags: review?(jdescottes)
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922108 - Flags: review?(jdescottes)
Attachment #8922108 - Attachment is obsolete: true
Attachment #8922108 - Flags: review?(jdescottes)
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922110 - Flags: review?(jdescottes)
Attachment #8922110 - Attachment is obsolete: true
Attachment #8922110 - Flags: review?(jdescottes)
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922112 - Flags: review?(jdescottes)
Attachment #8922112 - Attachment is obsolete: true
Attachment #8922112 - Flags: review?(jdescottes)
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922113 - Flags: review?(jdescottes)
Attachment #8922113 - Attachment is obsolete: true
Attachment #8922113 - Flags: review?(jdescottes)
Attached patch patch-10-25-3.patch (obsolete) — Splinter Review
Attachment #8922114 - Flags: review?(jdescottes)
seeing an issue w/ the wasm test...
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 58
Version: 57 Branch → unspecified
Attachment #8922114 - Attachment is obsolete: true
Attachment #8922114 - Flags: review?(jdescottes)
Attached patch patch-10-25-4.patch (obsolete) — Splinter Review
Attachment #8922851 - Flags: review?(jdescottes)
Attachment #8922851 - Attachment is obsolete: true
Attachment #8922851 - Flags: review?(jdescottes)
Attached patch patch-10-25-6.patch (obsolete) — Splinter Review
Attachment #8922874 - Flags: review?(jdescottes)
Attachment #8922874 - Attachment is obsolete: true
Attachment #8922874 - Flags: review?(jdescottes)
Attached patch patch-10-25-6.patch (obsolete) — Splinter Review
Attachment #8922903 - Flags: review?(jdescottes)
Attachment #8922903 - Attachment is obsolete: true
Attachment #8922903 - Flags: review?(jdescottes)
Attachment #8922939 - Flags: review?(jdescottes)
With the new patch, the disabled icons for stepping are almost impossible to differentiate from the enabled ones.
Comment on attachment 8922939 [details] [diff] [review]
patch-10-25-7.patch

Review of attachment 8922939 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, just one issue with the disabled icons (see previous comment + screenshot). 
Up to you if you want to fix it here or not.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: d9f18b2cd0792de70289d4dcde5ed3e38be87cf1

We discussed this on slack, but for the record: a good evolution for this would be to add the actual link to the debugger commit on GitHub. Even better would be to have a link to the compare view between this commit and the previous release commit.

Finally this information could also be added to the commit message (this way people who don't know about this file could still get the information easily.
Attachment #8922939 - Flags: review?(jdescottes) → review+
Lets push this patch and we'll fix the disable state in GH and patch on monday.

Thanks for the updates on the readme, i made an issue for it here: https://github.com/jasonLaster/ship2gecko/issues/2
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/129dfaaf265a
Update Debugger frontend (10-25). r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/129dfaaf265a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1430672
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.