Closed Bug 1411743 Opened 3 years ago Closed 3 years ago

Resolve a few warnings in tests exposed by MinGW build

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This bug holds a smattering of really trivial ones.

There was a comparison between DWORD (unsigned) and -1 that I don't have the log for.  

There's also this one:

> /home/tom/Documents/moz/mingw-work/just-build-18/widget/windows/gtest/TestEMFConversion.cpp:88:26: error: ignoring return value of ‘bool mozilla::Vector<T, N, AllocPolicy>::initCapacity(size_t) [with T = char; unsigned int MinInlineCapacity = 0u; AllocPolicy = mozilla::MallocAllocPolicy; size_t = unsigned int]’, declared with attribute warn_unused_result [-Werror=unused-result]
>    aBuf.initCapacity(size);
Try run to make sure nothing is broken: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e13dc72034cdbdf482143dac3a70dc3dec6d057 (Except MinGW which is missing a commit and verified elsewhere)
Comment on attachment 8922076 [details]
Bug 1411743 Resolve warnings in tests for MinGW: Cast -1 to DWORD, and ignore a result explicitly

https://reviewboard.mozilla.org/r/193062/#review199136
Attachment #8922076 - Flags: review?(jmathies) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/553b2d547b68
Resolve warnings in tests for MinGW: Cast -1 to DWORD, and ignore a result explicitly r=jimm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/553b2d547b68
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.