1411743 - Resolve a few warnings in tests exposed by MinGW build

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Tom Ritter [:tjr] (ni? for response to sec-[advisories/bounties/ratings/cves])]

This bug holds a smattering of really trivial ones.

There was a comparison between DWORD (unsigned) and -1 that I don't have the log for.  

There's also this one:

> /home/tom/Documents/moz/mingw-work/just-build-18/widget/windows/gtest/TestEMFConversion.cpp:88:26: error: ignoring return value of ‘bool mozilla::Vector<T, N, AllocPolicy>::initCapacity(size_t) [with T = char; unsigned int MinInlineCapacity = 0u; AllocPolicy = mozilla::MallocAllocPolicy; size_t = unsigned int]’, declared with attribute warn_unused_result [-Werror=unused-result]
>    aBuf.initCapacity(size);

Comment 1

[Tom Ritter [:tjr] (ni? for response to sec-[advisories/bounties/ratings/cves])]

Attachment: Bug 1411743 Resolve warnings in tests for MinGW: Cast -1 to DWORD, and ignore a result explicitly

Review commit: https://reviewboard.mozilla.org/r/193062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193062/

Comment 2

[Tom Ritter [:tjr] (ni? for response to sec-[advisories/bounties/ratings/cves])]

Try run to make sure nothing is broken: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e13dc72034cdbdf482143dac3a70dc3dec6d057 (Except MinGW which is missing a commit and verified elsewhere)

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8922076 [details]
Bug 1411743 Resolve warnings in tests for MinGW: Cast -1 to DWORD, and ignore a result explicitly

https://reviewboard.mozilla.org/r/193062/#review199136

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553b2d547b68
Resolve warnings in tests for MinGW: Cast -1 to DWORD, and ignore a result explicitly r=jimm

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/553b2d547b68